[
https://issues.apache.org/jira/browse/BEAM-3818?focusedWorklogId=81603&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-81603
]
ASF GitHub Bot logged work on BEAM-3818:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Mar/18 19:28
Start Date: 17/Mar/18 19:28
Worklog Time Spent: 10m
Work Description: mariapython commented on a change in pull request
#4838: [BEAM-3818] Add support for streaming side inputs in the DirectRunner
(part I: update _SideInputsContainer as the watermark advances)
URL: https://github.com/apache/beam/pull/4838#discussion_r175267711
##########
File path: sdks/python/apache_beam/runners/direct/evaluation_context.py
##########
@@ -217,11 +242,13 @@ def handle_result(
self._side_inputs_container.add_values(
view,
committed_bundle.get_elements_iterable(make_copy=True))
- if (self.get_execution_context(result.transform)
- .watermarks.input_watermark
- == WatermarkManager.WATERMARK_POS_INF):
- self._pending_unblocked_tasks.extend(
- self._side_inputs_container.finalize_value_and_get_tasks(view))
+
+ # Tasks generated from unblocked side inputs as the watermark progresses.
+ tasks = self._watermark_manager.update_watermarks(
+ completed_bundle, result.transform, completed_timers,
+ committed_bundles, unprocessed_bundles, result.keyed_watermark_holds,
+ self._side_inputs_container)
+ self._pending_unblocked_tasks.extend(tasks)
Review comment:
I pushed all the changes earlier today and was going to say the same (the
update needs to be regardless). That is why this was not modified in my last
commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 81603)
Time Spent: 3h 40m (was: 3.5h)
> Add support for the streaming side inputs in the Python DirectRunner
> --------------------------------------------------------------------
>
> Key: BEAM-3818
> URL: https://issues.apache.org/jira/browse/BEAM-3818
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: María GH
> Assignee: María GH
> Priority: Minor
> Fix For: 3.0.0
>
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> The streaming DirectRunner should support streaming side input semantics.
> Currently, side inputs are only available for globally-windowed side input
> PCollections.
> Also, empty side inputs cause a pipeline stall.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
