[
https://issues.apache.org/jira/browse/BEAM-3249?focusedWorklogId=81670&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-81670
]
ASF GitHub Bot logged work on BEAM-3249:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Mar/18 17:22
Start Date: 18/Mar/18 17:22
Worklog Time Spent: 10m
Work Description: lukecwik closed pull request #4830: [BEAM-3249,
BEAM-3457] Make Apache Rat a dependency of the Java and Gradle precommits.
URL: https://github.com/apache/beam/pull/4830
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/build.gradle b/build.gradle
index 69502ab77c0..ac800c40c0b 100644
--- a/build.gradle
+++ b/build.gradle
@@ -278,7 +278,10 @@ rat {
// Proto/grpc generated wrappers
"**/apache_beam/portability/api/*_pb2*.py",
- "**/go/pkg/beam/model/**/*.pb.go",
+ "**/go/pkg/beam/**/*.pb.go",
+
+ // Ignore Go test data files
+ "**/go/data/**",
// VCF test files
"**/apache_beam/testing/data/vcf/*",
@@ -290,20 +293,14 @@ check.dependsOn rat
// to be specified on the commandline when executing locally.
// This indirection also makes Jenkins use the branch of the PR
// for the test definitions.
-
-def javaPreCommitRoots = [
- ":sdks:java:core",
- ":runners:direct-java",
- ":sdks:java:fn-execution",
-]
task javaPreCommit() {
- for (String javaPreCommitRoot : javaPreCommitRoots) {
- dependsOn javaPreCommitRoot + ":buildNeeded"
- dependsOn javaPreCommitRoot + ":buildDependents"
- }
+ dependsOn ":rat"
+ dependsOn ":sdks:java:core:buildNeeded"
+ dependsOn ":sdks:java:core:buildDependents"
dependsOn ":examples:java:preCommit"
}
task goPreCommit() {
+ dependsOn ":rat"
dependsOn ":sdks:go:test"
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 81670)
Time Spent: 7h (was: 6h 50m)
> Use Gradle to build/release project
> -----------------------------------
>
> Key: BEAM-3249
> URL: https://issues.apache.org/jira/browse/BEAM-3249
> Project: Beam
> Issue Type: Improvement
> Components: build-system, testing
> Reporter: Luke Cwik
> Assignee: Luke Cwik
> Priority: Major
> Time Spent: 7h
> Remaining Estimate: 0h
>
> I have collected data by running several builds against master using Gradle
> and Maven without using Gradle's support for incremental builds.
> Gradle (mins)
> min: 25.04
> max: 160.14
> median: 45.78
> average: 52.19
> stdev: 30.80
> Maven (mins)
> min: 56.86
> max: 216.55
> median: 87.93
> average: 109.10
> stdev: 48.01
> I excluded a few timeouts (240 mins) that happened during the Maven build
> from its numbers but we can see conclusively that Gradle is about twice as
> fast for the build when compared to Maven when run using Jenkins.
> Original dev@ thread:
> https://lists.apache.org/thread.html/225dddcfc78f39bbb296a0d2bbef1caf37e17677c7e5573f0b6fe253@%3Cdev.beam.apache.org%3E
> The data is available here
> https://docs.google.com/spreadsheets/d/1MHVjF-xoI49_NJqEQakUgnNIQ7Qbjzu8Y1q_h3dbF1M/edit?usp=sharing
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
