[ 
https://issues.apache.org/jira/browse/BEAM-3840?focusedWorklogId=81688&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-81688
 ]

ASF GitHub Bot logged work on BEAM-3840:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 18/Mar/18 20:27
            Start Date: 18/Mar/18 20:27
    Worklog Time Spent: 10m 
      Work Description: aaltay commented on a change in pull request #4853: 
[BEAM-3840] Get python mobile-gaming automating on core runners
URL: https://github.com/apache/beam/pull/4853#discussion_r175302364
 
 

 ##########
 File path: release/src/main/groovy/run_release_candidate_python_quickstart.sh
 ##########
 @@ -179,12 +111,13 @@ gpg --verify $ASC_FILE_NAME $BEAM_PYTHON_SDK
 
 print_separator "Creating new virtualenv and installing the SDK"
 virtualenv temp_virtualenv
-. temp_virtualenv/bin/activate && pip install $BEAM_PYTHON_SDK[gcp]
+. temp_virtualenv/bin/activate
 
 Review comment:
   You do not need to create a virtualenv before gcloud update. virtualenv is 
only meaningful for the pip install that is happening a few lines below. (Maybe 
gcloud can move before the installing the SDK section.)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 81688)
    Time Spent: 13.5h  (was: 13h 20m)

> Get Python Mobile-Gaming Running on Core Runners
> ------------------------------------------------
>
>                 Key: BEAM-3840
>                 URL: https://issues.apache.org/jira/browse/BEAM-3840
>             Project: Beam
>          Issue Type: Sub-task
>          Components: examples-python
>    Affects Versions: 2.5.0
>            Reporter: yifan zou
>            Assignee: yifan zou
>            Priority: Major
>             Fix For: 2.5.0
>
>          Time Spent: 13.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to