[ 
https://issues.apache.org/jira/browse/BEAM-3759?focusedWorklogId=81739&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-81739
 ]

ASF GitHub Bot logged work on BEAM-3759:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 19/Mar/18 06:43
            Start Date: 19/Mar/18 06:43
    Worklog Time Spent: 10m 
      Work Description: charlesccychen commented on a change in pull request 
#4763: [BEAM-3759] Add support for PaneInfo in WindowedValues
URL: https://github.com/apache/beam/pull/4763#discussion_r175341748
 
 

 ##########
 File path: sdks/python/apache_beam/utils/windowed_value.py
 ##########
 @@ -104,11 +211,12 @@ def __reduce__(self):
 
 
 # TODO(robertwb): Move this to a static method.
-def create(value, timestamp_micros, windows):
+def create(value, timestamp_micros, windows, pane_info=None):
 
 Review comment:
   <!--thread_id:cc_173302895_t; 
commit:aa1b931750aa409e1d26e603fccd0fd82b9484da; resolved:1-->
   <!--section:context-quote-->
   > **robertwb** wrote:
   > Just let the default value be PANE_INFO_UNKNOWN.
   
   <!--section:body-->
   Done.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 81739)
    Time Spent: 2h 10m  (was: 2h)

> Add support for PaneInfo descriptor in Python SDK
> -------------------------------------------------
>
>                 Key: BEAM-3759
>                 URL: https://issues.apache.org/jira/browse/BEAM-3759
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-py-core
>    Affects Versions: 2.3.0
>            Reporter: Charles Chen
>            Assignee: Charles Chen
>            Priority: Major
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> The PaneInfo descriptor allows a user to determine which particular 
> triggering emitted a value.  This allows the user to differentiate between 
> speculative (early), on-time (at end of window) and late value emissions 
> coming out of a GroupByKey.  We should add support for this feature in the 
> Python SDK.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to