[
https://issues.apache.org/jira/browse/BEAM-3882?focusedWorklogId=82084&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-82084
]
ASF GitHub Bot logged work on BEAM-3882:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Mar/18 23:22
Start Date: 19/Mar/18 23:22
Worklog Time Spent: 10m
Work Description: axelmagn opened a new pull request #4900: [BEAM-3882]
Fix StateRequestHandler interface to be idiomatic
URL: https://github.com/apache/beam/pull/4900
The previous implementation of StateRequestHandler did not conform
to Beam coding conventions. It should not have accepted a return
value as a parameter. This fix updates the interface to instead
return a CompletableStage.
R: @tgroh
CC: @aljoscha, @bsidhom, @lukecwik
------------------------
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the
change (usually before you start working on it). Trivial changes like typos do
not require a JIRA issue. Your pull request should address just this issue,
without pulling in other changes.
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue.
- [ ] Write a pull request description that is detailed enough to
understand:
- [ ] What the pull request does
- [ ] Why it does it
- [ ] How it does it
- [ ] Why this approach
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 82084)
Time Spent: 10m
Remaining Estimate: 0h
> Make StateRequestHandler::accept interface idiomatic.
> -----------------------------------------------------
>
> Key: BEAM-3882
> URL: https://issues.apache.org/jira/browse/BEAM-3882
> Project: Beam
> Issue Type: Improvement
> Components: runner-core
> Reporter: Axel Magnuson
> Assignee: Axel Magnuson
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> StateRequestHandler was based on some Dataflow SDK source code that does not
> conform to Beam coding conventions. In particular, the accept method takes
> its return value as a parameter, which is a code smell.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
