[
https://issues.apache.org/jira/browse/BEAM-3310?focusedWorklogId=82337&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-82337
]
ASF GitHub Bot logged work on BEAM-3310:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Mar/18 17:12
Start Date: 20/Mar/18 17:12
Worklog Time Spent: 10m
Work Description: echauchot commented on issue #4548: [BEAM-3310] Metrics
pusher
URL: https://github.com/apache/beam/pull/4548#issuecomment-374680280
And WDYT about renaming MetricsQueryResults accessors to get*()?
---
Review status: 27 of 55 files reviewed at latest revision, 2 unresolved
discussions.
---
*[runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/MetricsPusher.java,
line 150 at
r4](https://reviewable.io:443/reviews/apache/beam/4548#-L4lVum2AW-e7VztHFPo-r4-150:-L83OGZLq4Yu2i7tYVPN:bb7f2mf)
([raw
file](https://github.com/apache/beam/blob/0f6e024e15c516402e102593ea466c0b4b9d934c/runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/MetricsPusher.java#L150)):*
<details><summary><i>Previously, aromanenko-dev (Alexey Romanenko)
wrote…</i></summary><blockquote>
Just a small remark - Jenkins PreCommit_Java_MavenInstall complains on this:
_[ERROR]
src/main/java/org/apache/beam/runners/core/metrics/MetricsPusher.java:[149]
(javadoc) JavadocStyle: First sentence should end with a period._
</blockquote></details>
done
---
*[sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml, line 42
at
r3](https://reviewable.io:443/reviews/apache/beam/4548#-L4mb9MCqXj2PrgZGqt6:-L83OJ6PO2kDHFfDNczu:bkd2l20)
([raw
file](https://github.com/apache/beam/blob/452d524e9e93c8e415be809a41117be2367e64d4/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L42)):*
<details><summary><i>Previously, swegner (Scott Wegner)
wrote…</i></summary><blockquote>
`MetricsPusher` no longer has an `init()` method. Remove?
</blockquote></details>
yes I forgot, thx
---
*Comments from
[Reviewable](https://reviewable.io:443/reviews/apache/beam/4548#-:-L83O5WOSfVkcftxP4aE:bno6s6o)*
<!-- Sent from Reviewable.io -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 82337)
Time Spent: 2h 50m (was: 2h 40m)
> Push metrics to a backend in an runner agnostic way
> ---------------------------------------------------
>
> Key: BEAM-3310
> URL: https://issues.apache.org/jira/browse/BEAM-3310
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-core
> Reporter: Etienne Chauchot
> Assignee: Etienne Chauchot
> Priority: Major
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The idea is to avoid relying on the runners to provide access to the metrics
> (either at the end of the pipeline or while it runs) because they don't have
> all the same capabilities towards metrics (e.g. spark runner configures sinks
> like csv, graphite or in memory sinks using the spark engine conf). The
> target is to push the metrics in the common runner code so that no matter the
> chosen runner, a user can get his metrics out of beam.
> Here is the link to the discussion thread on the dev ML:
> https://lists.apache.org/thread.html/01a80d62f2df6b84bfa41f05e15fda900178f882877c294fed8be91e@%3Cdev.beam.apache.org%3E
> And the design doc:
> https://s.apache.org/runner_independent_metrics_extraction
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
