[
https://issues.apache.org/jira/browse/BEAM-3855?focusedWorklogId=82400&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-82400
]
ASF GitHub Bot logged work on BEAM-3855:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Mar/18 18:40
Start Date: 20/Mar/18 18:40
Worklog Time Spent: 10m
Work Description: herohde commented on a change in pull request #4908:
BEAM-3855: Add Protocol Buffer support
URL: https://github.com/apache/beam/pull/4908#discussion_r175877897
##########
File path: sdks/go/pkg/beam/core/typex/class.go
##########
@@ -76,6 +78,13 @@ func IsConcrete(t reflect.Type) bool {
return false
}
+ // TODO(wcn): perhaps we need an extension hook to teach this method
about
+ // types that are "concrete" because they are already sourced by
external code?
+ pt := reflect.TypeOf((*proto.Message)(nil)).Elem()
Review comment:
Small suggestion: made this a global similarly to other types elsewhere?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 82400)
Time Spent: 10m
Remaining Estimate: 0h
> Add Go SDK support for protobuf coder
> -------------------------------------
>
> Key: BEAM-3855
> URL: https://issues.apache.org/jira/browse/BEAM-3855
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Willy Lulciuc
> Assignee: Bill Neubauer
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This JIRA is for something functional. We might want to use the coder
> registry for a more general solution, when implemented.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
