[
https://issues.apache.org/jira/browse/BEAM-3861?focusedWorklogId=82409&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-82409
]
ASF GitHub Bot logged work on BEAM-3861:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Mar/18 18:53
Start Date: 20/Mar/18 18:53
Worklog Time Spent: 10m
Work Description: markflyhigh commented on a change in pull request
#4874: [BEAM-3861] Improve test infra in Python SDK for streaming end-to-end
test
URL: https://github.com/apache/beam/pull/4874#discussion_r175884963
##########
File path: sdks/python/apache_beam/runners/dataflow/test_dataflow_runner.py
##########
@@ -46,10 +52,39 @@ def run_pipeline(self, pipeline):
print (
'Found: https://console.cloud.google.com/dataflow/jobsDetail'
'/locations/%s/jobs/%s?project=%s' % (region_id, job_id, project))
- self.result.wait_until_finish()
+
+ if not options.view_as(StandardOptions).streaming:
+ self.result.wait_until_finish()
+ else:
+ # TODO: Ideally, we want to wait until workers start successfully.
+ self.wait_until_running()
Review comment:
I feel this is one preferred step of streaming test before executing
verifiers. In integration test class, people can use `PipelineStateMatcher` to
get a clear signal that the pipeline entered in RUNNING state (like
[here](https://github.com/apache/beam/pull/4874/files#diff-a7940d9c8528322f7e20488c31ee47d3R85)).
So they are confident to define/add following actions (like customized
verifiers).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 82409)
Time Spent: 2h (was: 1h 50m)
> Build test infra for end-to-end streaming test in Python SDK
> ------------------------------------------------------------
>
> Key: BEAM-3861
> URL: https://issues.apache.org/jira/browse/BEAM-3861
> Project: Beam
> Issue Type: Task
> Components: testing
> Reporter: Mark Liu
> Assignee: Mark Liu
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
