[
https://issues.apache.org/jira/browse/BEAM-3891?focusedWorklogId=82461&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-82461
]
ASF GitHub Bot logged work on BEAM-3891:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Mar/18 20:28
Start Date: 20/Mar/18 20:28
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #4907:
[BEAM-3891] Add a suborder parameter to Networks#topologicalOrder
URL: https://github.com/apache/beam/pull/4907#discussion_r175911337
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/graph/Networks.java
##########
@@ -143,8 +146,44 @@ public final NodeT apply(NodeT input) {
return visitedNodes;
}
- /** Returns a set of nodes sorted in topological order. */
- public static <NodeT, EdgeT> Iterable<NodeT> topologicalOrder(Network<NodeT,
EdgeT> network) {
+ /**
+ * Returns a set of nodes sorted in topological order.
+ *
+ * <p>The order that unordered nodes appear in the result iterable is
arbitrary.
Review comment:
Its best to just say that we rely on the network to provide an ordering
based upon its node order.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 82461)
Time Spent: 1h 10m (was: 1h)
> There should be some way to perform a Topological Sort with a stable output
> ---------------------------------------------------------------------------
>
> Key: BEAM-3891
> URL: https://issues.apache.org/jira/browse/BEAM-3891
> Project: Beam
> Issue Type: Bug
> Components: runner-core
> Reporter: Thomas Groh
> Assignee: Thomas Groh
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> This really means that there is some way to produce the same iterable, order
> included, based on some property of the nodes. This can be done via
> performing a sort before the elements are added to the collection of nodes
> under consideration.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
