[
https://issues.apache.org/jira/browse/BEAM-3893?focusedWorklogId=82476&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-82476
]
ASF GitHub Bot logged work on BEAM-3893:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Mar/18 20:53
Start Date: 20/Mar/18 20:53
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #4911:
[BEAM-3893] Add fallback to unauthenticated access for Go GCS IO
URL: https://github.com/apache/beam/pull/4911#discussion_r175918533
##########
File path: sdks/go/pkg/beam/util/gcsx/gcs.go
##########
@@ -39,6 +41,15 @@ func NewClient(ctx context.Context, scope string)
(*storage.Service, error) {
return storage.New(cl)
Review comment:
Is there any way to make the client load the credentials internally on the
first 401?
It seems like we should only get the credentials if they are asked. We
should still be able to pass in the scope that we want for the client.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 82476)
Time Spent: 0.5h (was: 20m)
> Go SDK GCS I/O shouldn't require credentials to read from public buckets
> ------------------------------------------------------------------------
>
> Key: BEAM-3893
> URL: https://issues.apache.org/jira/browse/BEAM-3893
> Project: Beam
> Issue Type: Bug
> Components: sdk-go
> Reporter: Henning Rohde
> Assignee: Henning Rohde
> Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> We should handle the case where application default credentials are not
> available for public reads. Wordcount running a container fails currently:
> 2018/03/20 20:03:00 Failed to execute job: panic: panic: failed to create GCE
> client: google: could not find default credentials. See
> https://developers.google.com/accounts/docs/application-default-credentials
> for more information. goroutine 1 [running]:
> runtime/debug.Stack(0xc4201728a0, 0xc39460, 0xc4201c0120)
> /usr/local/go/src/runtime/debug/stack.go:24 +0xa7
> github.com/apache/beam/sdks/go/pkg/beam/core/util/reflectx.CallNoPanic.func1(0xc420172f80)
>
> /foo/src/github.com/apache/beam/sdks/go/pkg/beam/core/util/reflectx/call.go:98
> +0x6e
> panic(0xc39460, 0xc4201c0120)
> /usr/local/go/src/runtime/panic.go:491 +0x283
> github.com/apache/beam/sdks/go/pkg/beam/io/textio/gcs.New(0x12f3500,
> 0xc420014060, 0xc420094c40, 0x2)
>
> /foo/src/github.com/apache/beam/sdks/go/pkg/beam/io/textio/gcs/gcs.go:44
> +0x16e
> github.com/apache/beam/sdks/go/pkg/beam/io/textio.newFileSystem(0x12f3500,
> 0xc420014060, 0xc420094c40, 0x31, 0xc420172b50, 0x4bf4ef, 0xc37e60, 0xc37e60)
> /foo/src/github.com/apache/beam/sdks/go/pkg/beam/io/textio/textio.go:68
> +0xac
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
