[
https://issues.apache.org/jira/browse/BEAM-3339?focusedWorklogId=82894&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-82894
]
ASF GitHub Bot logged work on BEAM-3339:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Mar/18 20:23
Start Date: 21/Mar/18 20:23
Worklog Time Spent: 10m
Work Description: tgroh commented on a change in pull request #4788:
[BEAM-3339] Mobile gaming automation for Java nightly snapshot on core runners
URL: https://github.com/apache/beam/pull/4788#discussion_r176225598
##########
File path: release/src/main/groovy/TestScripts.groovy
##########
@@ -95,16 +116,35 @@ class TestScripts {
}
}
- // Check for expected results in stdout of the last command
+ // Check for expected results in stdout of the last command, return boolean
+ public boolean seeKeyWord(String expected){
+ if (!var.lastText.contains(expected)){
Review comment:
This doesn't really do anything as written. Even if you want to inject a
predicate,
Even if it is important to do it with a method, just `return
var.lastText.contains(expected)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 82894)
Time Spent: 72h 40m (was: 72.5h)
> Create post-release testing of the nightly snapshots
> ----------------------------------------------------
>
> Key: BEAM-3339
> URL: https://issues.apache.org/jira/browse/BEAM-3339
> Project: Beam
> Issue Type: Improvement
> Components: testing
> Reporter: Alan Myrvold
> Assignee: Jason Kuster
> Priority: Major
> Time Spent: 72h 40m
> Remaining Estimate: 0h
>
> The nightly java snapshots in
> https://repository.apache.org/content/groups/snapshots/org/apache/beam should
> be verified by following the
> https://beam.apache.org/get-started/quickstart-java/ instructions, to verify
> that the release is usable.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
