[
https://issues.apache.org/jira/browse/BEAM-3744?focusedWorklogId=83026&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-83026
]
ASF GitHub Bot logged work on BEAM-3744:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Mar/18 01:50
Start Date: 22/Mar/18 01:50
Worklog Time Spent: 10m
Work Description: udim commented on a change in pull request #4901:
[BEAM-3744] Expand Pubsub read API for Python.
URL: https://github.com/apache/beam/pull/4901#discussion_r176270878
##########
File path: sdks/python/apache_beam/io/gcp/pubsub.py
##########
@@ -44,8 +68,8 @@
pubsub_pb2 = None
-__all__ = ['PubsubMessage', 'ReadMessagesFromPubSub', 'ReadStringsFromPubSub',
- 'WriteStringsToPubSub']
+__all__ = ['PubsubMessage', 'ReadMessagesFromPubSub', 'ReadPayloadsFromPubSub',
Review comment:
I am fine with supporting only 2 transforms: one for payload and the other
for payload with metadata.
If that's the case, then I argue we should get rid of ReadStringsFromPubSub,
since ReadPayloadsFromPubSub is more useful (and you could always add a decode
step to your pipeline).
If we agree on this, I'll remove ReadStringsFromPubSub and rename
WriteStringsToPubSub to WritePayloadsToPubSub in a subsequent PR (which will
also include a PTransform to write payloads with attributes).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 83026)
Time Spent: 6h (was: 5h 50m)
> Support full PubsubMessages
> ---------------------------
>
> Key: BEAM-3744
> URL: https://issues.apache.org/jira/browse/BEAM-3744
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Udi Meiri
> Assignee: Udi Meiri
> Priority: Critical
> Time Spent: 6h
> Remaining Estimate: 0h
>
> Tracking changes to Pubsub support in Python SDK.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
