[
https://issues.apache.org/jira/browse/BEAM-3910?focusedWorklogId=83390&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-83390
]
ASF GitHub Bot logged work on BEAM-3910:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Mar/18 23:55
Start Date: 22/Mar/18 23:55
Worklog Time Spent: 10m
Work Description: herohde commented on a change in pull request #4941:
BEAM-3910: Add float support for the Go SDK.
URL: https://github.com/apache/beam/pull/4941#discussion_r176606474
##########
File path: sdks/go/pkg/beam/core/runtime/graphx/v1/v1.proto
##########
@@ -46,6 +46,8 @@ message Type {
UINT32 = 10;
UINT64 = 11;
STRING = 12;
+ FLOAT32 = 13;
Review comment:
Don't we need changes to EncodeType/DecodeType as well that use them?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 83390)
Time Spent: 0.5h (was: 20m)
Remaining Estimate: 23.5h (was: 23h 40m)
> Support floating point values in Go SDK
> ---------------------------------------
>
> Key: BEAM-3910
> URL: https://issues.apache.org/jira/browse/BEAM-3910
> Project: Beam
> Issue Type: New Feature
> Components: sdk-go
> Reporter: Bill Neubauer
> Assignee: Bill Neubauer
> Priority: Major
> Original Estimate: 24h
> Time Spent: 0.5h
> Remaining Estimate: 23.5h
>
> The Go SDK supports all the integer types of the language, but does not
> support floats.
> My plan for coding is to use the same technique the gob package uses, which
> results in a compact encoding for simple values.
> [https://golang.org/src/encoding/gob/encode.go?#L210|https://golang.org/src/encoding/gob/encode.go#L210]
> with rationale explained in
> https://golang.org/pkg/encoding/gob/#hdr-Encoding_Details
> The resulting uint is then encoded using the existing coders in coderx.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
