[
https://issues.apache.org/jira/browse/BEAM-3892?focusedWorklogId=83513&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-83513
]
ASF GitHub Bot logged work on BEAM-3892:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Mar/18 09:00
Start Date: 23/Mar/18 09:00
Worklog Time Spent: 10m
Work Description: echauchot commented on issue #4918: [BEAM-3892] Make
MetricQueryResults and related classes more json-serialization friendly
URL: https://github.com/apache/beam/pull/4918#issuecomment-375585827
@swegner I extracted this commit in a separate PR because it is a breaking
change of the experimental metrics API. We agreed on this PR
https://github.com/apache/beam/pull/4548 to do so. So I add you as a reviewer
as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 83513)
Time Spent: 50m (was: 40m)
> Make MetricQueryResults and related classes more json-serialization friendly
> ----------------------------------------------------------------------------
>
> Key: BEAM-3892
> URL: https://issues.apache.org/jira/browse/BEAM-3892
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Etienne Chauchot
> Assignee: Etienne Chauchot
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> When working on this PR [https://github.com/apache/beam/pull/4548]
> MetricQueryResults needed to be serialized to be pushed to a metrics sink. As
> they were it required a custom serializer that just calls the name(),
> counter(), committed(), attempted() ... methods. MetricQueryResults are so
> close to be serializable with the default serializer, just need the accessors
> to be renamed get*, that creating DTO objects with get* methods to just call
> the non-get methods seems unnecessary.
> So just rename public accessors to get* on the experimental API
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
