[
https://issues.apache.org/jira/browse/BEAM-3060?focusedWorklogId=83710&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-83710
]
ASF GitHub Bot logged work on BEAM-3060:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Mar/18 17:37
Start Date: 23/Mar/18 17:37
Worklog Time Spent: 10m
Work Description: lukecwik closed pull request #4870: [BEAM-3060] Fixing
mvn dependency issue when runnning filebasedIOIT t…
URL: https://github.com/apache/beam/pull/4870
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/build.gradle b/build.gradle
index 69502ab77c0..9263f3a073d 100644
--- a/build.gradle
+++ b/build.gradle
@@ -44,6 +44,7 @@ def pubsub_grpc_version = "0.1.18"
def apex_core_version = "3.6.0"
def apex_malhar_version = "3.4.0"
def postgres_version = "9.4.1212.jre7"
+def jaxb_api_version = "2.2.12"
// A map of maps containing common libraries used per language. To use:
// dependencies {
@@ -125,6 +126,7 @@ ext.library = [
jackson_dataformat_cbor:
"com.fasterxml.jackson.dataformat:jackson-dataformat-cbor:$jackson_version",
jackson_dataformat_yaml:
"com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:$jackson_version",
jackson_module_scala:
"com.fasterxml.jackson.module:jackson-module-scala_2.11:$jackson_version",
+ jaxb_api: "javax.xml.bind:jaxb-api:$jaxb_api_version",
joda_time: "joda-time:joda-time:2.4",
junit: "junit:junit:4.12",
kafka_clients: "org.apache.kafka:kafka-clients:1.0.0",
diff --git a/pom.xml b/pom.xml
index 9573a07767f..0e10ac92a86 100644
--- a/pom.xml
+++ b/pom.xml
@@ -185,6 +185,7 @@
<compiler.default.pkginfo.flag>-Xpkginfo:always</compiler.default.pkginfo.flag>
<compiler.default.exclude>nothing</compiler.default.exclude>
<gax-grpc.version>0.20.0</gax-grpc.version>
+ <jaxb-api.version>2.2.12</jaxb-api.version>
<!-- standard binary for kubectl -->
<kubectl>kubectl</kubectl>
@@ -1498,6 +1499,13 @@
<classifier>tests</classifier>
<scope>test</scope>
</dependency>
+
+ <dependency>
+ <groupId>javax.xml.bind</groupId>
+ <artifactId>jaxb-api</artifactId>
+ <version>${jaxb-api.version}</version>
+ </dependency>
+
</dependencies>
</dependencyManagement>
diff --git a/sdks/java/io/file-based-io-tests/build.gradle
b/sdks/java/io/file-based-io-tests/build.gradle
index e797172850a..9e6eb0b2d26 100644
--- a/sdks/java/io/file-based-io-tests/build.gradle
+++ b/sdks/java/io/file-based-io-tests/build.gradle
@@ -39,4 +39,5 @@ dependencies {
shadowTest library.java.guava
shadowTest library.java.junit
shadowTest library.java.hamcrest_core
+ shadowTest library.java.jaxb_api
}
diff --git a/sdks/java/io/file-based-io-tests/pom.xml
b/sdks/java/io/file-based-io-tests/pom.xml
index c66537c7b15..3de4ba55ae1 100644
--- a/sdks/java/io/file-based-io-tests/pom.xml
+++ b/sdks/java/io/file-based-io-tests/pom.xml
@@ -294,6 +294,11 @@
<version>${apache.hadoop.version}</version>
<scope>runtime</scope>
</dependency>
+ <dependency>
+ <groupId>javax.xml.bind</groupId>
+ <artifactId>jaxb-api</artifactId>
+ <scope>test</scope>
+ </dependency>
</dependencies>
</profile>
</profiles>
diff --git a/sdks/java/io/xml/build.gradle b/sdks/java/io/xml/build.gradle
index 5e66ad96f35..af07424990f 100644
--- a/sdks/java/io/xml/build.gradle
+++ b/sdks/java/io/xml/build.gradle
@@ -27,6 +27,7 @@ dependencies {
shadow library.java.stax2_api
shadow library.java.findbugs_jsr305
shadow library.java.woodstox_core_asl
+ shadowTest library.java.jaxb_api
testCompile project(path: ":sdks:java:core", configuration: "shadowTest")
testCompile project(path: ":runners:direct-java", configuration: "shadow")
testCompile library.java.junit
diff --git a/sdks/java/io/xml/pom.xml b/sdks/java/io/xml/pom.xml
index d0a3d5f7396..85ecd4ec2a2 100644
--- a/sdks/java/io/xml/pom.xml
+++ b/sdks/java/io/xml/pom.xml
@@ -109,6 +109,12 @@
<artifactId>hamcrest-library</artifactId>
<scope>test</scope>
</dependency>
+
+ <dependency>
+ <groupId>javax.xml.bind</groupId>
+ <artifactId>jaxb-api</artifactId>
+ <scope>test</scope>
+ </dependency>
</dependencies>
<profiles>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 83710)
Time Spent: 5h (was: 4h 50m)
> Add performance tests for commonly used file-based I/O PTransforms
> ------------------------------------------------------------------
>
> Key: BEAM-3060
> URL: https://issues.apache.org/jira/browse/BEAM-3060
> Project: Beam
> Issue Type: Test
> Components: sdk-java-core
> Reporter: Chamikara Jayalath
> Assignee: Szymon Nieradka
> Priority: Major
> Time Spent: 5h
> Remaining Estimate: 0h
>
> We recently added a performance testing framework [1] that can be used to do
> following.
> (1) Execute Beam tests using PerfkitBenchmarker
> (2) Manage Kubernetes-based deployments of data stores.
> (3) Easily publish benchmark results.
> I think it will be useful to add performance tests for commonly used
> file-based I/O PTransforms using this framework. I suggest looking into
> following formats initially.
> (1) AvroIO
> (2) TextIO
> (3) Compressed text using TextIO
> (4) TFRecordIO
> It should be possibly to run these tests for various Beam runners (Direct,
> Dataflow, Flink, Spark, etc.) and file-systems (GCS, local, HDFS, etc.)
> easily.
> In the initial version, tests can be made manually triggerable for PRs
> through Jenkins. Later, we could make some of these tests run periodically
> and publish benchmark results (to BigQuery) through PerfkitBenchmarker.
> [1] https://beam.apache.org/documentation/io/testing/
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
