[
https://issues.apache.org/jira/browse/BEAM-3931?focusedWorklogId=84757&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-84757
]
ASF GitHub Bot logged work on BEAM-3931:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Mar/18 07:14
Start Date: 27/Mar/18 07:14
Worklog Time Spent: 10m
Work Description: iemejia closed pull request #4952: [BEAM-3931] Remove
commons-text dependency from Spark runner
URL: https://github.com/apache/beam/pull/4952
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/build.gradle b/build.gradle
index 97f4d1fc42d..a977302048d 100644
--- a/build.gradle
+++ b/build.gradle
@@ -73,7 +73,6 @@ ext.library = [
commons_io_1x: "commons-io:commons-io:1.3.2",
commons_io_2x: "commons-io:commons-io:2.5",
commons_lang3: "org.apache.commons:commons-lang3:3.6",
- commons_text: "org.apache.commons:commons-text:1.1",
datastore_v1_proto_client:
"com.google.cloud.datastore:datastore-v1-proto-client:1.4.0",
datastore_v1_protos:
"com.google.cloud.datastore:datastore-v1-protos:1.3.0",
error_prone_annotations:
"com.google.errorprone:error_prone_annotations:2.0.15",
diff --git a/pom.xml b/pom.xml
index 6326f70e1fe..228b593c1d8 100644
--- a/pom.xml
+++ b/pom.xml
@@ -104,7 +104,6 @@
<!-- If updating dependencies, please update any relevant javadoc
offlineLinks -->
<apache.commons.compress.version>1.16.1</apache.commons.compress.version>
<apache.commons.lang.version>3.6</apache.commons.lang.version>
- <apache.commons.text.version>1.1</apache.commons.text.version>
<apex.kryo.version>2.24.0</apex.kryo.version>
<api-common.version>1.0.0-rc2</api-common.version>
<args4j.version>2.33</args4j.version>
@@ -828,12 +827,6 @@
<version>${apache.commons.lang.version}</version>
</dependency>
- <dependency>
- <groupId>org.apache.commons</groupId>
- <artifactId>commons-text</artifactId>
- <version>${apache.commons.text.version}</version>
- </dependency>
-
<dependency>
<groupId>io.grpc</groupId>
<artifactId>grpc-all</artifactId>
diff --git a/runners/spark/build.gradle b/runners/spark/build.gradle
index 268769843f6..7eccf4f405e 100644
--- a/runners/spark/build.gradle
+++ b/runners/spark/build.gradle
@@ -58,7 +58,6 @@ dependencies {
shadow library.java.jackson_annotations
shadow library.java.slf4j_api
shadow library.java.joda_time
- shadow library.java.commons_text
shadow "io.dropwizard.metrics:metrics-core:3.1.2"
shadow "com.fasterxml.jackson.module:jackson-module-scala_2.11:2.8.9"
provided library.java.spark_core
diff --git a/runners/spark/pom.xml b/runners/spark/pom.xml
index 4e5e791a7a1..a9b90dc999d 100644
--- a/runners/spark/pom.xml
+++ b/runners/spark/pom.xml
@@ -223,10 +223,6 @@
<artifactId>commons-lang3</artifactId>
<scope>provided</scope>
</dependency>
- <dependency>
- <groupId>org.apache.commons</groupId>
- <artifactId>commons-text</artifactId>
- </dependency>
<dependency>
<groupId>commons-io</groupId>
<artifactId>commons-io</artifactId>
diff --git
a/runners/spark/src/main/java/org/apache/beam/runners/spark/SparkNativePipelineVisitor.java
b/runners/spark/src/main/java/org/apache/beam/runners/spark/SparkNativePipelineVisitor.java
index 57022f446be..0e0f620c9d8 100644
---
a/runners/spark/src/main/java/org/apache/beam/runners/spark/SparkNativePipelineVisitor.java
+++
b/runners/spark/src/main/java/org/apache/beam/runners/spark/SparkNativePipelineVisitor.java
@@ -33,7 +33,7 @@
import org.apache.beam.sdk.transforms.PTransform;
import org.apache.beam.sdk.values.PInput;
import org.apache.beam.sdk.values.POutput;
-import org.apache.commons.text.WordUtils;
+import org.apache.commons.lang3.StringUtils;
/**
* Pipeline visitor for translating a Beam pipeline into equivalent Spark
operations.
@@ -175,7 +175,7 @@ private String replaceFnString(
throws IllegalAccessException, InvocationTargetException,
NoSuchMethodException,
NoSuchFieldException {
Object fn =
- transformClass.getMethod("get" +
WordUtils.capitalize(fnFieldName)).invoke(transform);
+ transformClass.getMethod("get" +
StringUtils.capitalize(fnFieldName)).invoke(transform);
Class<?> fnClass = fn.getClass();
String doFnName;
Class<?> enclosingClass = fnClass.getEnclosingClass();
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 84757)
Time Spent: 1.5h (was: 1h 20m)
> Remove commons-text dependency from Spark runner
> ------------------------------------------------
>
> Key: BEAM-3931
> URL: https://issues.apache.org/jira/browse/BEAM-3931
> Project: Beam
> Issue Type: Improvement
> Components: runner-spark
> Affects Versions: 2.5.0
> Reporter: Ismaël Mejía
> Assignee: Ismaël Mejía
> Priority: Trivial
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The spark runner has a dependency to commons-text that is used only in a
> trivial use case to capitalize method calls, We can use StringUtils instead
> of this and remove a global dependency in the project.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
