[
https://issues.apache.org/jira/browse/BEAM-3545?focusedWorklogId=85037&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-85037
]
ASF GitHub Bot logged work on BEAM-3545:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Mar/18 21:54
Start Date: 27/Mar/18 21:54
Worklog Time Spent: 10m
Work Description: herohde commented on a change in pull request #4899:
[BEAM-3545] Go SDK UserCounters
URL: https://github.com/apache/beam/pull/4899#discussion_r177582549
##########
File path: sdks/go/pkg/beam/core/runtime/harness/harness.go
##########
@@ -203,20 +204,44 @@ func (c *control) handleInstruction(ctx context.Context,
req *fnpb.InstructionRe
err := plan.Execute(ctx, id, c.data)
+ snapshot := plan.ProgressReport()
+ planID := plan.ID()
// Move the plan back to the candidate state
c.mu.Lock()
c.plans[plan.ID()] = plan
delete(c.active, id)
c.mu.Unlock()
+ transforms := map[string]*fnpb.Metrics_PTransform{
Review comment:
We could add another method that returns the Metrics (incl. progress report)
to achieve the same thing, if we call ProgressReport from multiple places. That
would keep the ParDo IDs and the code that uses it together, which I think will
make the code easier to follow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 85037)
Time Spent: 8h 40m (was: 8.5h)
> Fn API metrics in Go SDK harness
> --------------------------------
>
> Key: BEAM-3545
> URL: https://issues.apache.org/jira/browse/BEAM-3545
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Kenneth Knowles
> Assignee: Robert Burke
> Priority: Major
> Labels: portability
> Time Spent: 8h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
