[
https://issues.apache.org/jira/browse/BEAM-3326?focusedWorklogId=85428&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-85428
]
ASF GitHub Bot logged work on BEAM-3326:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Mar/18 22:53
Start Date: 28/Mar/18 22:53
Worklog Time Spent: 10m
Work Description: lukecwik closed pull request #4970: [BEAM-3326] Address
additional comments from PR/4963.
URL: https://github.com/apache/beam/pull/4970
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/control/SdkHarnessClient.java
b/runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/control/SdkHarnessClient.java
index de1aa57fe32..ebcb8b4d33f 100644
---
a/runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/control/SdkHarnessClient.java
+++
b/runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/control/SdkHarnessClient.java
@@ -180,7 +180,7 @@ public String getBundleId() {
/**
* Returns a {@link FnDataReceiver receiver} which consumes input elements
forwarding them
- * to the SDK. When
+ * to the SDK.
*/
public FnDataReceiver<WindowedValue<InputT>> getInputReceiver() {
return inputReceiver;
@@ -211,8 +211,9 @@ public void close() throws Exception {
if (exception == null) {
MoreFutures.get(response);
} else {
- // TODO: Handle aborting the bundle being processed.
- throw new IllegalStateException("Processing bundle failed, TODO:
abort bundle.");
+ // TODO: [BEAM-3962] Handle aborting the bundle being processed.
+ throw new IllegalStateException("Processing bundle failed, "
+ + "TODO: [BEAM-3962] abort bundle.");
}
} catch (Exception e) {
if (exception == null) {
diff --git
a/runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/data/FnDataService.java
b/runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/data/FnDataService.java
index 6c7839fc193..d86324eb366 100644
---
a/runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/data/FnDataService.java
+++
b/runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/data/FnDataService.java
@@ -38,9 +38,9 @@
* <p>The provided coder is used to decode inbound elements. The decoded
elements are passed to
* the provided receiver.
*
- * <p>Any failure during decoding or processing of the element will complete
the returned future
- * exceptionally. On successful termination of the stream, the returned
future is completed
- * successfully.
+ * <p>Any failure during decoding or processing of the element will put the
+ * {@link InboundDataClient} into an error state such that
+ * {@link InboundDataClient#awaitCompletion()} will throw an exception.
*
* <p>The provided receiver is not required to be thread safe.
*/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 85428)
Time Spent: 5.5h (was: 5h 20m)
> Execute a Stage via the portability framework in the ReferenceRunner
> --------------------------------------------------------------------
>
> Key: BEAM-3326
> URL: https://issues.apache.org/jira/browse/BEAM-3326
> Project: Beam
> Issue Type: New Feature
> Components: runner-core
> Reporter: Thomas Groh
> Assignee: Thomas Groh
> Priority: Major
> Labels: portability
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
> This is the supertask for remote execution in the Universal Local Runner
> (BEAM-2899).
> This executes a stage remotely via portability framework APIs
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
