[ 
https://issues.apache.org/jira/browse/BEAM-3818?focusedWorklogId=86083&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-86083
 ]

ASF GitHub Bot logged work on BEAM-3818:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 30/Mar/18 17:20
            Start Date: 30/Mar/18 17:20
    Worklog Time Spent: 10m 
      Work Description: charlesccychen commented on a change in pull request 
#4949: [BEAM-3818] Add support for streaming side inputs in the DirectRunner 
(part 2: unblock tasks as the _SideInputsContainer gets updated) 
URL: https://github.com/apache/beam/pull/4949#discussion_r178331820
 
 

 ##########
 File path: sdks/python/apache_beam/runners/direct/executor.py
 ##########
 @@ -288,11 +295,16 @@ def call(self):
     scoped_metrics_container = ScopedMetricsContainer(metrics_container)
 
     for side_input in self._applied_ptransform.side_inputs:
+      # Find the projection of main's window onto the side input's window
 
 Review comment:
   <!--new_thread; commit:0d82258b7674656d3a6f86748f47d23de8cf512f; 
resolved:0-->
   Period at end of sentence.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 86083)
    Time Spent: 5h 20m  (was: 5h 10m)

> Add support for the streaming side inputs in the Python DirectRunner
> --------------------------------------------------------------------
>
>                 Key: BEAM-3818
>                 URL: https://issues.apache.org/jira/browse/BEAM-3818
>             Project: Beam
>          Issue Type: New Feature
>          Components: sdk-py-core
>            Reporter: María GH
>            Assignee: María GH
>            Priority: Minor
>             Fix For: 3.0.0
>
>          Time Spent: 5h 20m
>  Remaining Estimate: 0h
>
> The streaming DirectRunner should support streaming side input semantics.  
> Currently, side inputs are only available for globally-windowed side input 
> PCollections.
> Also, empty side inputs cause a pipeline stall.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to