[
https://issues.apache.org/jira/browse/BEAM-3437?focusedWorklogId=86098&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-86098
]
ASF GitHub Bot logged work on BEAM-3437:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Mar/18 17:53
Start Date: 30/Mar/18 17:53
Worklog Time Spent: 10m
Work Description: akedin commented on a change in pull request #4964:
[BEAM-3437] Introduce Schema class, and use it in BeamSQL
URL: https://github.com/apache/beam/pull/4964#discussion_r178337973
##########
File path:
sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamJoinRelUnboundedVsBoundedTest.java
##########
@@ -51,44 +51,44 @@
@Rule
public final TestPipeline pipeline = TestPipeline.create();
private static final BeamSqlEnv BEAM_SQL_ENV = new BeamSqlEnv();
- public static final Date FIRST_DATE = new Date(1);
- public static final Date SECOND_DATE = new Date(1 + 3600 * 1000);
- public static final Date THIRD_DATE = new Date(1 + 3600 * 1000 + 3600 * 1000
+ 1);
+ public static final DateTime FIRST_DATE = new DateTime(1);
+ public static final DateTime SECOND_DATE = new DateTime(1 + 3600 * 1000);
+ public static final DateTime THIRD_DATE = new DateTime(1 + 3600 * 1000 +
3600 * 1000 + 1);
private static final Duration WINDOW_SIZE = Duration.standardHours(1);
@BeforeClass
public static void prepare() {
BEAM_SQL_ENV.registerTable("ORDER_DETAILS", MockedUnboundedTable
.of(
- SqlTypeCoders.INTEGER, "order_id",
- SqlTypeCoders.INTEGER, "site_id",
- SqlTypeCoders.INTEGER, "price",
- SqlTypeCoders.TIMESTAMP, "order_time"
+ FieldType.INT32, "order_id",
+ FieldType.INT32, "site_id",
+ FieldType.INT32, "price",
+ FieldType.INT32, "order_time"
Review comment:
Why not `FieldType.DATETIME` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 86098)
Time Spent: 1h 10m (was: 1h)
> Support schema in PCollections
> ------------------------------
>
> Key: BEAM-3437
> URL: https://issues.apache.org/jira/browse/BEAM-3437
> Project: Beam
> Issue Type: Wish
> Components: beam-model
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> As discussed with some people in the team, it would be great to add schema
> support in {{PCollections}}. It will allow us:
> 1. To expect some data type in {{PTransforms}}
> 2. Improve some runners with additional features (I'm thinking about Spark
> runner with data frames for instance).
> A technical draft document has been created:
> https://docs.google.com/document/d/1tnG2DPHZYbsomvihIpXruUmQ12pHGK0QIvXS1FOTgRc/edit?disco=AAAABhykQIs&ts=5a203b46&usp=comment_email_document
> I also started a PoC on a branch, I will update this Jira with a "discussion"
> PR.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
