[
https://issues.apache.org/jira/browse/BEAM-3981?focusedWorklogId=86722&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-86722
]
ASF GitHub Bot logged work on BEAM-3981:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Apr/18 19:57
Start Date: 02/Apr/18 19:57
Worklog Time Spent: 10m
Work Description: charlesccychen commented on a change in pull request
#4990: [BEAM-3981] Futurize and fix python 2 compatibility for coders subpackage
URL: https://github.com/apache/beam/pull/4990#discussion_r178633430
##########
File path: sdks/python/apache_beam/coders/stream.pxd
##########
@@ -23,7 +23,7 @@ cdef class OutputStream(object):
cdef size_t buffer_size
cdef size_t pos
- cpdef write(self, bytes b, bint nested=*)
+ cpdef write(self, b, bint nested=*)
Review comment:
<!--new_thread; commit:57a73055b9447e7a1fe6ad674673254d9a614eeb;
resolved:0-->
I'm not sure removing this type annotation is the right thing to do, for
performance...
CC: @robertwb, who could provide more guidance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 86722)
Time Spent: 1h (was: 50m)
> Futurize and fix python 2 compatibility for coders package
> ----------------------------------------------------------
>
> Key: BEAM-3981
> URL: https://issues.apache.org/jira/browse/BEAM-3981
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Ahmet Altay
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Run automatic conversion with futurize tool on coders subpackage and fix
> python 2 compatibility. This prepares the subpackage for python 3 support.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
