[
https://issues.apache.org/jira/browse/BEAM-3952?focusedWorklogId=86852&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-86852
]
ASF GitHub Bot logged work on BEAM-3952:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Apr/18 23:52
Start Date: 02/Apr/18 23:52
Worklog Time Spent: 10m
Work Description: tgroh opened a new pull request #4995:
[BEAM-3952][BEAM-3988] Fix GreedyPipelineFuser test
URL: https://github.com/apache/beam/pull/4995
The test was not considering the downstream `Window` in a different
environment as a primitive, and thus it was being dropped by the
construction of the `QueryablePipeline`.
Also, updated `QueryablePipeline` to consider any node with no
subtransforms as a primitive.
------------------------
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the
change (usually before you start working on it). Trivial changes like typos do
not require a JIRA issue. Your pull request should address just this issue,
without pulling in other changes.
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue.
- [ ] Write a pull request description that is detailed enough to
understand:
- [ ] What the pull request does
- [ ] Why it does it
- [ ] How it does it
- [ ] Why this approach
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 86852)
Time Spent: 10m
Remaining Estimate: 0h
> GreedyStageFuserTest broken
> ---------------------------
>
> Key: BEAM-3952
> URL: https://issues.apache.org/jira/browse/BEAM-3952
> Project: Beam
> Issue Type: Bug
> Components: runner-core
> Reporter: Ben Sidhom
> Assignee: Thomas Groh
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The materializesWithDifferentEnvConsumer test is currently failing due to a
> bad assertion. The fused subgraph contains the parDo.out PCollection but the
> test expects an empty output.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
