[
https://issues.apache.org/jira/browse/BEAM-3774?focusedWorklogId=87155&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-87155
]
ASF GitHub Bot logged work on BEAM-3774:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Apr/18 16:41
Start Date: 03/Apr/18 16:41
Worklog Time Spent: 10m
Work Description: tgroh commented on a change in pull request #5001:
[BEAM-3774] Adds support for reading from/writing to more BQ geographical
locations
URL: https://github.com/apache/beam/pull/5001#discussion_r178887991
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java
##########
@@ -687,7 +696,7 @@ public void validate(PipelineOptions options) {
new JobConfigurationQuery()
.setQuery(getQuery().get())
.setFlattenResults(getFlattenResults())
- .setUseLegacySql(getUseLegacySql()));
+ .setUseLegacySql(getUseLegacySql()), getQueryLocation());
Review comment:
Newline between the `JobConfigurationQuery` and the location, as it reads as
though it's part of that configuration (which I don't think it is)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 87155)
Time Spent: 0.5h (was: 20m)
> Update BigQuery jobs to explicitly specify the region
> -----------------------------------------------------
>
> Key: BEAM-3774
> URL: https://issues.apache.org/jira/browse/BEAM-3774
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Chamikara Jayalath
> Assignee: Chamikara Jayalath
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> This is needed to support BQ regions other than US and EU. Region can be
> obtained by a Dataset.get() request so no need to update the user API.
> Both Python and Java SDKs have to be updated.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
