[
https://issues.apache.org/jira/browse/BEAM-3989?focusedWorklogId=87275&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-87275
]
ASF GitHub Bot logged work on BEAM-3989:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Apr/18 20:58
Start Date: 03/Apr/18 20:58
Worklog Time Spent: 10m
Work Description: lukecwik closed pull request #5005: [BEAM-3989] Delete
unused pipeline jobs
URL: https://github.com/apache/beam/pull/5005
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.test-infra/jenkins/PreCommit_Pipeline.groovy
b/.test-infra/jenkins/PreCommit_Pipeline.groovy
deleted file mode 100644
index 131c79845ab..00000000000
--- a/.test-infra/jenkins/PreCommit_Pipeline.groovy
+++ /dev/null
@@ -1,129 +0,0 @@
-#!groovy
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-import hudson.model.Result
-
-int NO_BUILD = -1
-
-// These are args for the GitHub Pull Request Builder (ghprb) Plugin.
Providing these arguments is
-// necessary due to a bug in the ghprb plugin where environment variables are
not correctly passed
-// to jobs downstream of a Pipeline job.
-// Tracked by https://github.com/jenkinsci/ghprb-plugin/issues/572.
-List<Object> ghprbArgs = [
- string(name: 'ghprbGhRepository', value: "${ghprbGhRepository}"),
- string(name: 'ghprbActualCommit', value: "${ghprbActualCommit}"),
- string(name: 'ghprbPullId', value: "${ghprbPullId}")
-]
-
-// This argument is the commit at which to build.
-List<Object> commitArg = [string(name: 'sha1', value:
"origin/pr/${ghprbPullId}/head")]
-
-int javaBuildNum = NO_BUILD
-
-final String JAVA_BUILD_TYPE = "java"
-final String PYTHON_BUILD_TYPE = "python"
-final String ALL_BUILD_TYPE = "all"
-
-def buildTypes = [
- JAVA_BUILD_TYPE,
- PYTHON_BUILD_TYPE,
- ALL_BUILD_TYPE,
-]
-
-String currentBuildType = ALL_BUILD_TYPE
-String commentLower = ghprbCommentBody.toLowerCase()
-
-// Currently if there is nothing selected (e.g. the comment is just "retest
this please") we select "all" by default.
-// In the future we should provide some mechanism, either via commenting or
the suite failure message, to enforce
-// selection of one of the build types.
-if (!commentLower.isEmpty()) {
- commentSplit = commentLower.split(' ')
- buildType = commentSplit[commentSplit.length-1]
- if (buildTypes.contains(buildType)) {
- currentBuildType = buildType
- }
-}
-
-// This (and the below) define "Stages" of a pipeline. These stages run
serially, and inside can
-// have "parallel" blocks which execute several work steps concurrently. This
work is limited to
-// simple operations -- more complicated operations need to be performed on an
actual node. In this
-// case we are using the pipeline to trigger downstream builds.
-stage('Build') {
- parallel (
- java: {
- if (currentBuildType == JAVA_BUILD_TYPE || currentBuildType ==
ALL_BUILD_TYPE) {
- def javaBuild = build job: 'beam_Java_Build', parameters:
commitArg + ghprbArgs
- if (javaBuild.getResult() == Result.SUCCESS.toString()) {
- javaBuildNum = javaBuild.getNumber()
- }
- } else {
- echo 'Skipping Java due to comment selecting non-Java
execution: ' + ghprbCommentBody
- }
- },
- python_unit: { // Python doesn't have a build phase, so we include
this here.
- if (currentBuildType == PYTHON_BUILD_TYPE || currentBuildType ==
ALL_BUILD_TYPE) {
- try {
- build job: 'beam_Python_UnitTest', parameters: commitArg +
ghprbArgs
- } catch (Exception e) {
- echo 'Python build failed: ' + e.toString()
- }
- } else {
- echo 'Skipping Python due to comment selecting non-Python
execution: ' + ghprbCommentBody
- }
- }
- )
-}
-
-// This argument is provided to downstream jobs so they know from which build
to pull artifacts.
-javaBuildArg = [string(name: 'buildNum', value: "${javaBuildNum}")]
-javaUnitPassed = false
-
-stage('Unit Test / Code Health') {
- parallel (
- java_unit: {
- if(javaBuildNum != NO_BUILD) {
- def javaTest = build job: 'beam_Java_UnitTest', parameters:
javaBuildArg + ghprbArgs
- if(javaTest.getResult() == Result.SUCCESS.toString()) {
- javaUnitPassed = true
- }
- }
- },
- java_codehealth: {
- if(javaBuildNum != NO_BUILD) {
- try {
- build job: 'beam_Java_CodeHealth', parameters:
javaBuildArg + ghprbArgs
- } catch (Exception e) {
- echo 'Java CodeHealth Build Failed: ' + e.toString()
- }
- }
- }
- )
-}
-
-stage('Integration Test') {
- parallel (
- // Not gated on codehealth because codehealth shouldn't affect whether
tests provide useful
- // signal.
- java_integration: {
- if(javaUnitPassed) {
- build job: 'beam_Java_IntegrationTest', parameters:
javaBuildArg + ghprbArgs
- }
- }
- )
-}
diff --git a/.test-infra/jenkins/job_beam_PreCommit_Pipeline.groovy
b/.test-infra/jenkins/job_beam_PreCommit_Pipeline.groovy
deleted file mode 100644
index dadc10cd763..00000000000
--- a/.test-infra/jenkins/job_beam_PreCommit_Pipeline.groovy
+++ /dev/null
@@ -1,84 +0,0 @@
-
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-import common_job_properties
-
-// This job owns the overall execution of the precommit pipeline. The actual
pipeline code is in
-// Precommit_Pipeline.groovy.
-pipelineJob('beam_PreCommit_Pipeline') {
- description('PreCommit Pipeline Job. Owns overall lifecycle of PreCommit
tests.')
-
- properties {
- githubProjectUrl('https://github.com/apache/beam/')
- }
-
- parameters {
- // Allow building at a specific commit.
- stringParam(
- 'commit',
- 'master',
- 'Commit id or refname (e.g. origin/pr/9/head) you want to build.')
- }
-
- wrappers {
- // Set a timeout appropriate for the precommit tests.
- timeout {
- absolute(120)
- abortBuild()
- }
- }
-
- // Restrict this project to run only on Jenkins executors as specified
- label('beam')
-
- // Execute concurrent builds if necessary.
- concurrentBuild()
-
- triggers {
- githubPullRequest {
- admins(['asfbot'])
- useGitHubHooks()
- orgWhitelist(['apache'])
- allowMembersOfWhitelistedOrgsAsAdmin()
- permitAll()
- // Remove once Pipeline Build is default.
- triggerPhrase('^Run PreCommit Pipeline (((Python|Java))|All)$')
- onlyTriggerPhrase()
- displayBuildErrorsOnDownstreamBuilds()
- extensions {
- commitStatus {
- context("Jenkins: PreCommit Pipeline")
- }
- buildStatus {
- completedStatus('SUCCESS', '--none--')
- completedStatus('FAILURE', '--none--')
- completedStatus('ERROR', '--none--')
- }
- }
- }
- }
-
- definition {
- cpsScm {
- // Source code management.
- common_job_properties.setSCM(delegate, 'beam')
- scriptPath('.test-infra/jenkins/PreCommit_Pipeline.groovy')
- }
- }
-}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 87275)
Time Spent: 1h 10m (was: 1h)
> Maven pipeline jobs consistently failing
> ----------------------------------------
>
> Key: BEAM-3989
> URL: https://issues.apache.org/jira/browse/BEAM-3989
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
> Reporter: Alan Myrvold
> Assignee: Alan Myrvold
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> These jobs are failing or disabled:
> * beam_Java_Build
> * beam_Java_CodeHealth
> * beam_Java_IntegrationTest
> * beam_Java_UnitTest
> * beam_Python_UnitTest
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
