[
https://issues.apache.org/jira/browse/BEAM-3956?focusedWorklogId=87351&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-87351
]
ASF GitHub Bot logged work on BEAM-3956:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Apr/18 23:57
Start Date: 03/Apr/18 23:57
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #4959:
[BEAM-3956] Preserve stacktraces for Python exceptions
URL: https://github.com/apache/beam/pull/4959#discussion_r178990621
##########
File path: sdks/python/apache_beam/transforms/ptransform_test.py
##########
@@ -2015,8 +2015,8 @@ def test_runtime_type_check_python_type_error(self):
# Our special type-checking related TypeError shouldn't have been raised.
# Instead the above pipeline should have triggered a regular Python runtime
# TypeError.
- self.assertEqual("object of type 'int' has no len() [while running 'Len']",
- e.exception.args[0])
+ expected_start = "object of type 'int' has no len() [while running 'Len']"
+ self.assertEqual(expected_start, e.exception.args[0][:len(expected_start)])
Review comment:
can we use str.startswith() here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 87351)
Time Spent: 1h 40m (was: 1.5h)
> Stacktraces from exceptions in user code should be preserved in the Python SDK
> ------------------------------------------------------------------------------
>
> Key: BEAM-3956
> URL: https://issues.apache.org/jira/browse/BEAM-3956
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Stephan Hoyer
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Currently, Beam's Python SDK loses stacktraces for exceptions. It does
> helpfully add a tag like "[while running StageA]" to exception error
> messages, but that doesn't include the stacktrace of Python functions being
> called.
> Including the full stacktraces would make a big difference for the ease of
> debugging Beam pipelines when things go wrong.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
