[ 
https://issues.apache.org/jira/browse/BEAM-3973?focusedWorklogId=88019&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-88019
 ]

ASF GitHub Bot logged work on BEAM-3973:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 05/Apr/18 12:46
            Start Date: 05/Apr/18 12:46
    Worklog Time Spent: 10m 
      Work Description: iemejia commented on a change in pull request #4946: 
[BEAM-3973] Adds a parameter to the Cloud Spanner read connector that can 
disable batch API
URL: https://github.com/apache/beam/pull/4946#discussion_r179449485
 
 

 ##########
 File path: 
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerReadIT.java
 ##########
 @@ -193,6 +184,59 @@ public void testQuery() throws Exception {
     p.run();
   }
 
+  private SpannerConfig createSpannerConfig() {
+    return SpannerConfig.create()
+        .withProjectId(project)
+        .withInstanceId(options.getInstanceId())
+        .withDatabaseId(databaseName);
+  }
+
+  @Test
+  public void testReadAllRecordsInDb() throws Exception {
+    DatabaseClient databaseClient = getDatabaseClient();
+
+    List<Mutation> mutations = new ArrayList<>();
 
 Review comment:
   I referred also to this part too, and what I expected was more in the line 
of a makeTableData method like [BigtableIOTest's 
one](https://github.com/apache/beam/blob/50a84326581941bc1edf573a0ad2b798ecb0f6a1/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIOTest.java#L995).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 88019)
    Time Spent: 2h  (was: 1h 50m)

> Allow to disable batch API in SpannerIO
> ---------------------------------------
>
>                 Key: BEAM-3973
>                 URL: https://issues.apache.org/jira/browse/BEAM-3973
>             Project: Beam
>          Issue Type: Bug
>          Components: io-java-gcp
>    Affects Versions: 2.4.0
>            Reporter: Mairbek Khadikov
>            Assignee: Mairbek Khadikov
>            Priority: Major
>             Fix For: 2.5.0
>
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> In 2.4.0, SpannerIO#read has been migrated to use batch API. The batch API 
> provides abstractions to scale out reads from Spanner, but it requires the 
> query to be root-partitionable. The root-partitionable queries cover majority 
> of the use cases, however there are examples when running arbitrary query is 
> useful. For example, reading all the table names from the 
> information_schema.* and reading the content of those tables in the next 
> step. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to