ASF GitHub Bot logged work on BEAM-3355:

                Author: ASF GitHub Bot
            Created on: 06/Apr/18 17:25
            Start Date: 06/Apr/18 17:25
    Worklog Time Spent: 10m 
      Work Description: herohde commented on a change in pull request #4311: 
[BEAM-3355] Diagnostic interfaces
URL: https://github.com/apache/beam/pull/4311#discussion_r179815311

 File path: sdks/go/pkg/beam/core/runtime/harness/session.go
 @@ -213,3 +186,59 @@ func recordFooter() error {
+// CaptureHook writes the messaging content consumed and
+// produced by the worker, allowing the data to be used as
+// an input for the session runner. Since workers can exist
+// in a variety of environments, this allows the runner
+// to tailor the behavior best for its particular needs.
+type CaptureHook io.WriteCloser
 Review comment:
   nit: rename it CaptureWriter? I was confused when reading the code by it 
also called a hook.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 88508)
    Time Spent: 6h 10m  (was: 6h)

> Make Go SDK runtime harness hooks pluggable
> -------------------------------------------
>                 Key: BEAM-3355
>                 URL: https://issues.apache.org/jira/browse/BEAM-3355
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-go
>            Reporter: Henning Rohde
>            Assignee: Bill Neubauer
>            Priority: Minor
>          Time Spent: 6h 10m
>  Remaining Estimate: 0h
> We currently hardcode cpu profiling and session recording in the harness. We 
> should make it pluggable instead.

This message was sent by Atlassian JIRA

Reply via email to