[
https://issues.apache.org/jira/browse/BEAM-3994?focusedWorklogId=89189&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-89189
]
ASF GitHub Bot logged work on BEAM-3994:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Apr/18 23:22
Start Date: 09/Apr/18 23:22
Worklog Time Spent: 10m
Work Description: tgroh commented on a change in pull request #5008:
[BEAM-3994] Use typed client pool sinks and sources
URL: https://github.com/apache/beam/pull/5008#discussion_r180258693
##########
File path:
sdks/java/fn-execution/src/main/java/org/apache/beam/sdk/fn/function/package-info.java
##########
@@ -16,7 +16,5 @@
* limitations under the License.
*/
-/**
- * Java 8 functional interface extensions.
- */
-package org.apache.beam.fn.harness.fn;
+/** Java 8 functional utilities for fn-execution. */
Review comment:
"utilities" seems wrong as the overall claim - I prefer the previous comment
- though you could definitely have "extensions to functional interfaces and
utilities" if we're introducing utilities
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 89189)
Time Spent: 1h 50m (was: 1h 40m)
> Use typed sinks and sources for FnApiControlClientPoolService
> -------------------------------------------------------------
>
> Key: BEAM-3994
> URL: https://issues.apache.org/jira/browse/BEAM-3994
> Project: Beam
> Issue Type: Bug
> Components: runner-core
> Reporter: Ben Sidhom
> Assignee: Ben Sidhom
> Priority: Minor
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> We operate with blocking queues directly when managing control clients with
> the FnApiControlClientPoolService. This makes interactions with the client
> pool difficult to understand. We should instead make client sources and sinks
> explicit.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
