[ 
https://issues.apache.org/jira/browse/BEAM-4034?focusedWorklogId=89215&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-89215
 ]

ASF GitHub Bot logged work on BEAM-4034:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/Apr/18 01:46
            Start Date: 10/Apr/18 01:46
    Worklog Time Spent: 10m 
      Work Description: wcn3 commented on issue #5065: [BEAM-4034] Fix hooks 
panic with Go on Flink
URL: https://github.com/apache/beam/pull/5065#issuecomment-379947303
 
 
   Bit late, but could we have GetOptionWithDefault as a vehicle? That way, the 
default value could be "{}" which would unmarshal as empty options, and then we 
wouldn't need the warning paths. WDYT?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 89215)
    Time Spent: 1h  (was: 50m)

> Hooks panic on flink
> --------------------
>
>                 Key: BEAM-4034
>                 URL: https://issues.apache.org/jira/browse/BEAM-4034
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-go
>            Reporter: Henning Rohde
>            Assignee: Henning Rohde
>            Priority: Major
>             Fix For: 2.5.0
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> It seems the serialized hooks are set only for Dataflow. It should probably 
> not panic if nothing is set. I see the below on Flink.
> $ docker logs 0f5
> 2018/04/09 21:03:48 Initializing Go harness: /opt/apache/beam/boot --id=-123 
> --logging_endpoint=docker.for.mac.host.internal:61723 
> --artifact_endpoint=docker.for.mac.host.internal:61724 
> --provision_endpoint=docker.for.mac.host.internal:61725 
> --control_endpoint=docker.for.mac.host.internal:61721 
> --semi_persist_dir=/tmp/semi_persistent_dir2198305397089608348
> Worker panic: DeserializeHooks failed on input "": unexpected end of JSON 
> inputgoroutine 1 [running]:
> runtime/debug.Stack(0x4f, 0x0, 0x0)
>       /usr/local/go/src/runtime/debug/stack.go:24 +0xa7
> runtime/debug.PrintStack()
>       /usr/local/go/src/runtime/debug/stack.go:16 +0x22
> github.com/apache/beam/sdks/go/pkg/beam/core/runtime/harness/init.hook.func1()
>       
> /Users/herohde/go/src/github.com/apache/beam/sdks/go/pkg/beam/core/runtime/harness/init/init.go:76
>  +0xb6
> panic(0xc65060, 0xc4200402a0)
>       /usr/local/go/src/runtime/panic.go:491 +0x283
> github.com/apache/beam/sdks/go/pkg/beam/core/util/hooks.DeserializeHooksFromOptions()
>       
> /Users/herohde/go/src/github.com/apache/beam/sdks/go/pkg/beam/core/util/hooks/hooks.go:135
>  +0x402
> github.com/apache/beam/sdks/go/pkg/beam/core/runtime/harness.Main(0x136dd00, 
> 0xc420060010, 0x7ffdcfb0dda8, 0x22, 0x7ffdcfb0ddde, 0x22, 0x0, 0x0)
>       
> /Users/herohde/go/src/github.com/apache/beam/sdks/go/pkg/beam/core/runtime/harness/harness.go:41
>  +0x4f
> github.com/apache/beam/sdks/go/pkg/beam/core/runtime/harness/init.hook()
>       
> /Users/herohde/go/src/github.com/apache/beam/sdks/go/pkg/beam/core/runtime/harness/init/init.go:84
>  +0xc1
> github.com/apache/beam/sdks/go/pkg/beam/core/runtime.Init()
>       
> /Users/herohde/go/src/github.com/apache/beam/sdks/go/pkg/beam/core/runtime/init.go:42
>  +0x4c
> github.com/apache/beam/sdks/go/pkg/beam.Init()
>       
> /Users/herohde/go/src/github.com/apache/beam/sdks/go/pkg/beam/forward.go:63 
> +0x20
> main.main()
>       
> /Users/herohde/go/src/github.com/apache/beam/sdks/go/examples/wordcount/wordcount.go:156
>  +0x39
> 2018/04/09 21:03:49 User program exited: exit status 2



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to