ASF GitHub Bot logged work on BEAM-3042:

                Author: ASF GitHub Bot
            Created on: 10/Apr/18 16:39
            Start Date: 10/Apr/18 16:39
    Worklog Time Spent: 10m 
      Work Description: pabloem commented on a change in pull request #5075: 
[BEAM-3042] Refactor of TransformIOCounters (performance, inheritance). Time 
counter for sideinputs.
URL: https://github.com/apache/beam/pull/5075#discussion_r180488970

 File path: sdks/python/apache_beam/runners/worker/sideinputs.py
 @@ -73,7 +73,24 @@ def __init__(self,
     # Whether an error was encountered in any source reader.
     self.has_errored = False
-    self.read_counter = read_counter or opcounters.TransformIOCounter()
+    self.read_counter = read_counter or opcounters.NoOpTransformIOCounter()
+    experiments = RuntimeValueProvider.get_value('experiments', list, [])
+    if 'sideinput_io_metrics' in experiments:
 Review comment:
   Hi Ahmet. This experiment was already ongoing when we decided to start using 
versioned experiment strings. Since we have only rolled out to internal 
projects, it must be fine to keep the first string version (and later use 
`_v2`). WDYT?

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 89484)
    Time Spent: 1h 40m  (was: 1.5h)

> Add tracking of bytes read / time spent when reading side inputs
> ----------------------------------------------------------------
>                 Key: BEAM-3042
>                 URL: https://issues.apache.org/jira/browse/BEAM-3042
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py-core
>            Reporter: Pablo Estrada
>            Assignee: Pablo Estrada
>            Priority: Major
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
> It is difficult for Dataflow users to understand how modifying a pipeline or 
> data set can affect how much inter-transform IO is used in their job. The 
> intent of this feature request is to help users understand how side inputs 
> behave when they are consumed.
> This will allow users to understand how much time and how much data their 
> pipeline uses to read/write to inter-transform IO. Users will also be able to 
> modify their pipelines and understand how their changes affect these IO 
> metrics.
> For further information, please review the internal Google doc 
> go/insights-transform-io-design-doc.

This message was sent by Atlassian JIRA

Reply via email to