[ 
https://issues.apache.org/jira/browse/BEAM-4031?focusedWorklogId=89505&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-89505
 ]

ASF GitHub Bot logged work on BEAM-4031:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/Apr/18 17:17
            Start Date: 10/Apr/18 17:17
    Worklog Time Spent: 10m 
      Work Description: tgroh closed pull request #5070: [BEAM-4031] Add more 
Go SDK Dataflow options
URL: https://github.com/apache/beam/pull/5070
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/sdks/go/pkg/beam/runners/dataflow/dataflow.go 
b/sdks/go/pkg/beam/runners/dataflow/dataflow.go
index 4173c9f4f5a..cdc8221b9b9 100644
--- a/sdks/go/pkg/beam/runners/dataflow/dataflow.go
+++ b/sdks/go/pkg/beam/runners/dataflow/dataflow.go
@@ -53,6 +53,10 @@ var (
        stagingLocation = flag.String("staging_location", "", "GCS staging 
location (required).")
        image           = flag.String("worker_harness_container_image", "", 
"Worker harness container image (required).")
        numWorkers      = flag.Int64("num_workers", 0, "Number of workers 
(optional).")
+       zone            = flag.String("zone", "", "GCP zone (optional)")
+       network         = flag.String("network", "", "GCP network (optional)")
+       tempLocation    = flag.String("temp_location", "", "Temp location 
(optional)")
+       machineType     = flag.String("worker_machine_type", "", "GCE machine 
type (optional)")
 
        dryRun         = flag.Bool("dry_run", false, "Dry run. Just print the 
job, but don't submit it.")
        teardownPolicy = flag.String("teardown_policy", "", "Job teardown 
policy (internal only).")
@@ -174,6 +178,9 @@ func Execute(ctx context.Context, p *beam.Pipeline) error {
                                }},
                                WorkerHarnessContainerImage: *image,
                                NumWorkers:                  1,
+                               MachineType:                 *machineType,
+                               Network:                     *network,
+                               Zone:                        *zone,
                        }},
                        TempStoragePrefix: *stagingLocation + "/tmp",
                        Experiments:       jobopts.GetExperiments(),
@@ -187,6 +194,9 @@ func Execute(ctx context.Context, p *beam.Pipeline) error {
        if *teardownPolicy != "" {
                job.Environment.WorkerPools[0].TeardownPolicy = *teardownPolicy
        }
+       if *tempLocation != "" {
+               job.Environment.TempStoragePrefix = *tempLocation
+       }
        printJob(ctx, job)
 
        if *dryRun {


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 89505)
    Time Spent: 1h  (was: 50m)

> Add missing dataflow customization options for Go SDK
> -----------------------------------------------------
>
>                 Key: BEAM-4031
>                 URL: https://issues.apache.org/jira/browse/BEAM-4031
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-go
>            Reporter: Henning Rohde
>            Assignee: Henning Rohde
>            Priority: Minor
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> We're missing at least:
> zone
> temp_location
> worker_machine_type



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to