[ 
https://issues.apache.org/jira/browse/BEAM-3036?focusedWorklogId=89718&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-89718
 ]

ASF GitHub Bot logged work on BEAM-3036:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/Apr/18 23:46
            Start Date: 10/Apr/18 23:46
    Worklog Time Spent: 10m 
      Work Description: youngoli opened a new pull request #5094: [BEAM-3036] 
Fixing Checkstyle error in IntelliJ.
URL: https://github.com/apache/beam/pull/5094
 
 
   It seems that recent versions of Checkstyle have broken the script
   so that Checkstyle is not properly loaded in IntelliJ. This change
   updates the Checkstyle file.
   
   The error had to do with the SuppressionCommentFilter not allowed to be a 
child of TreeWalker so I moved it outside of TreeWalker and Checkstyle now 
seems to work in my IntelliJ.
   
   ------------------------
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
    - [x] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the 
change (usually before you start working on it).  Trivial changes like typos do 
not require a JIRA issue.  Your pull request should address just this issue, 
without pulling in other changes.
    - [x] Format the pull request title like `[BEAM-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA 
issue.
    - [x] Write a pull request description that is detailed enough to 
understand:
      - [x] What the pull request does
      - [x] Why it does it
      - [x] How it does it
      - [x] Why this approach
    - [x] Each commit in the pull request should have a meaningful subject line 
and body.
    - [x] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 89718)
            Time Spent: 10m
    Remaining Estimate: 0h

> Checkstyle error in IntelliJ
> ----------------------------
>
>                 Key: BEAM-3036
>                 URL: https://issues.apache.org/jira/browse/BEAM-3036
>             Project: Beam
>          Issue Type: Task
>          Components: website
>            Reporter: Kwang-in (Dennis) JUNG
>            Assignee: Daniel Oliveira
>            Priority: Trivial
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Hello.
> I'm following Beam contribution guide, and encountered at some bug when 
> setting checkstyle.
> 1.Install the “Checkstyle-IDEA” plugin from the IntelliJ plugin repository.
> 2.Configure the plugin by going to Settings -> Other Settings -> Checkstyle.
> 3.Set the “Scan Scope” to “Only Java sources (including tests)”.
> 4.In the “Configuration File” pane, add a new configuration using the plus 
> icon:
>   4-1.Set the “Description” to “Beam”.
>   4-2.Select “Use a local Checkstyle file”, and point it to 
> “sdks/java/build-tools/src/main/resources/beam/checkstyle.xml” within your 
> repository.
>   4-3.Check the box for “Store relative to project location”, and click 
> “Next”.
>   4-4.Configure the “checkstyle.suppressions.file” property value to 
> “suppressions.xml”, and click “Next”, then “Finish”.
> After I click Next in 4-4, it shows error below in dialog box.
> ```
> org.infernus.idea.checkstyle.exception.CheckStylePluginException: 
> <html><b>The Checkstyle rules file could not be 
> parsed.</b><br>SuppressionCommentFilter is not allowed as a child in 
> Checker<br>The file has been blacklisted for 60s.</html>
>       at 
> org.infernus.idea.checkstyle.checker.CheckerFactory.blacklistAndShowMessage(CheckerFactory.java:198)
>       at 
> org.infernus.idea.checkstyle.checker.CheckerFactory.blacklistAndShowMessage(CheckerFactory.java:214)
>       at 
> org.infernus.idea.checkstyle.checker.CheckerFactory.createChecker(CheckerFactory.java:146)
>       at 
> org.infernus.idea.checkstyle.checker.CheckerFactory.getOrCreateCachedChecker(CheckerFactory.java:74)
>       at 
> org.infernus.idea.checkstyle.checker.CheckerFactory.checker(CheckerFactory.java:56)
>       at 
> org.infernus.idea.checkstyle.checker.CheckerFactory.verify(CheckerFactory.java:43)
>       at 
> org.infernus.idea.checkstyle.ui.LocationDialogue.attemptLoadOfFile(LocationDialogue.java:205)
>       at 
> org.infernus.idea.checkstyle.ui.LocationDialogue.access$800(LocationDialogue.java:35)
>       at 
> org.infernus.idea.checkstyle.ui.LocationDialogue$NextAction.actionPerformed(LocationDialogue.java:256)
>       at 
> javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2022)
>       at 
> javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2348)
>       at 
> javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:402)
>       at 
> javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:259)
>       at 
> javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:252)
>       at 
> java.awt.AWTEventMulticaster.mouseReleased(AWTEventMulticaster.java:289)
>       at java.awt.Component.processMouseEvent(Component.java:6541)
>       at javax.swing.JComponent.processMouseEvent(JComponent.java:3324)
>       at java.awt.Component.processEvent(Component.java:6306)
>       at java.awt.Container.processEvent(Container.java:2237)
>       at java.awt.Component.dispatchEventImpl(Component.java:4897)
>       at java.awt.Container.dispatchEventImpl(Container.java:2295)
>       at java.awt.Component.dispatchEvent(Component.java:4719)
>       at 
> java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4889)
>       at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4526)
>       at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4467)
>       at java.awt.Container.dispatchEventImpl(Container.java:2281)
>       at java.awt.Window.dispatchEventImpl(Window.java:2746)
>       at java.awt.Component.dispatchEvent(Component.java:4719)
>       at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:764)
>       at java.awt.EventQueue.access$500(EventQueue.java:98)
>       at java.awt.EventQueue$3.run(EventQueue.java:715)
>       at java.awt.EventQueue$3.run(EventQueue.java:709)
>       at java.security.AccessController.doPrivileged(Native Method)
>       at 
> java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:80)
>       at 
> java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:90)
>       at java.awt.EventQueue$4.run(EventQueue.java:737)
>       at java.awt.EventQueue$4.run(EventQueue.java:735)
>       at java.security.AccessController.doPrivileged(Native Method)
>       at 
> java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:80)
>       at java.awt.EventQueue.dispatchEvent(EventQueue.java:734)
>       at 
> com.intellij.ide.IdeEventQueue.defaultDispatchEvent(IdeEventQueue.java:821)
>       at com.intellij.ide.IdeEventQueue._dispatchEvent(IdeEventQueue.java:645)
>       at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.java:365)
>       at 
> java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:201)
>       at 
> java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
>       at 
> java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:109)
>       at java.awt.WaitDispatchSupport$2.run(WaitDispatchSupport.java:190)
>       at java.awt.WaitDispatchSupport$4.run(WaitDispatchSupport.java:235)
>       at java.awt.WaitDispatchSupport$4.run(WaitDispatchSupport.java:233)
>       at java.security.AccessController.doPrivileged(Native Method)
>       at java.awt.WaitDispatchSupport.enter(WaitDispatchSupport.java:233)
>       at java.awt.Dialog.show(Dialog.java:1084)
>       at java.awt.Component.show(Component.java:1679)
>       at java.awt.Component.setVisible(Component.java:1631)
>       at java.awt.Window.setVisible(Window.java:1014)
>       at java.awt.Dialog.setVisible(Dialog.java:1005)
>       at 
> org.infernus.idea.checkstyle.ui.LocationDialogue.setVisible(LocationDialogue.java:158)
>       at 
> org.infernus.idea.checkstyle.ui.CheckStyleConfigPanel$AddLocationAction.actionPerformed(CheckStyleConfigPanel.java:268)
>       at 
> org.infernus.idea.checkstyle.ui.CheckStyleConfigPanel$ToolbarAction.run(CheckStyleConfigPanel.java:356)
>       at 
> org.infernus.idea.checkstyle.ui.CheckStyleConfigPanel$ToolbarAction.run(CheckStyleConfigPanel.java:351)
>       at com.intellij.ui.ToolbarDecorator$2.doAdd(ToolbarDecorator.java:440)
>       at 
> com.intellij.ui.CommonActionsPanel$Buttons.performAction(CommonActionsPanel.java:72)
>       at 
> com.intellij.ui.CommonActionsPanel$MyActionButton.actionPerformed(CommonActionsPanel.java:263)
>       at 
> com.intellij.openapi.actionSystem.ex.ActionUtil$1.run(ActionUtil.java:216)
>       at 
> com.intellij.openapi.actionSystem.ex.ActionUtil.performActionDumbAware(ActionUtil.java:233)
>       at 
> com.intellij.openapi.actionSystem.impl.ActionButton.actionPerformed(ActionButton.java:192)
>       at 
> com.intellij.openapi.actionSystem.impl.ActionButton.performAction(ActionButton.java:155)
>       at 
> com.intellij.openapi.actionSystem.impl.ActionButton.processMouseEvent(ActionButton.java:329)
>       at java.awt.Component.processEvent(Component.java:6306)
>       at java.awt.Container.processEvent(Container.java:2237)
>       at java.awt.Component.dispatchEventImpl(Component.java:4897)
>       at java.awt.Container.dispatchEventImpl(Container.java:2295)
>       at java.awt.Component.dispatchEvent(Component.java:4719)
>       at 
> java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4889)
>       at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4526)
>       at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4467)
>       at java.awt.Container.dispatchEventImpl(Container.java:2281)
>       at java.awt.Window.dispatchEventImpl(Window.java:2746)
>       at java.awt.Component.dispatchEvent(Component.java:4719)
>       at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:764)
>       at java.awt.EventQueue.access$500(EventQueue.java:98)
>       at java.awt.EventQueue$3.run(EventQueue.java:715)
>       at java.awt.EventQueue$3.run(EventQueue.java:709)
>       at java.security.AccessController.doPrivileged(Native Method)
>       at 
> java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:80)
>       at 
> java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:90)
>       at java.awt.EventQueue$4.run(EventQueue.java:737)
>       at java.awt.EventQueue$4.run(EventQueue.java:735)
>       at java.security.AccessController.doPrivileged(Native Method)
>       at 
> java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:80)
>       at java.awt.EventQueue.dispatchEvent(EventQueue.java:734)
>       at 
> com.intellij.ide.IdeEventQueue.defaultDispatchEvent(IdeEventQueue.java:821)
>       at com.intellij.ide.IdeEventQueue._dispatchEvent(IdeEventQueue.java:645)
>       at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.java:365)
>       at 
> java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:201)
>       at 
> java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
>       at 
> java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:109)
>       at java.awt.WaitDispatchSupport$2.run(WaitDispatchSupport.java:190)
>       at java.awt.WaitDispatchSupport$4.run(WaitDispatchSupport.java:235)
>       at java.awt.WaitDispatchSupport$4.run(WaitDispatchSupport.java:233)
>       at java.security.AccessController.doPrivileged(Native Method)
>       at java.awt.WaitDispatchSupport.enter(WaitDispatchSupport.java:233)
>       at java.awt.Dialog.show(Dialog.java:1084)
>       at 
> com.intellij.openapi.ui.impl.DialogWrapperPeerImpl$MyDialog.show(DialogWrapperPeerImpl.java:736)
>       at 
> com.intellij.openapi.ui.impl.DialogWrapperPeerImpl.show(DialogWrapperPeerImpl.java:458)
>       at 
> com.intellij.openapi.ui.DialogWrapper.invokeShow(DialogWrapper.java:1686)
>       at com.intellij.openapi.ui.DialogWrapper.show(DialogWrapper.java:1635)
>       at 
> com.intellij.openapi.options.newEditor.SettingsDialog.lambda$show$0(SettingsDialog.java:83)
>       at 
> com.intellij.openapi.application.TransactionGuardImpl.runSyncTransaction(TransactionGuardImpl.java:86)
>       at 
> com.intellij.openapi.application.TransactionGuardImpl.submitTransactionAndWait(TransactionGuardImpl.java:151)
>       at 
> com.intellij.openapi.options.newEditor.SettingsDialog.show(SettingsDialog.java:83)
>       at 
> com.intellij.ide.actions.ShowSettingsUtilImpl.showSettingsDialog(ShowSettingsUtilImpl.java:97)
>       at 
> com.intellij.ide.actions.ShowSettingsAction.perform(ShowSettingsAction.java:63)
>       at 
> com.intellij.ide.MacOSApplicationProvider$Worker.lambda$null$1(MacOSApplicationProvider.java:118)
>       at 
> com.intellij.ide.MacOSApplicationProvider$Worker.lambda$submit$6(MacOSApplicationProvider.java:212)
>       at 
> com.intellij.openapi.application.TransactionGuardImpl.runSyncTransaction(TransactionGuardImpl.java:86)
>       at 
> com.intellij.openapi.application.TransactionGuardImpl.lambda$pollQueueLater$0(TransactionGuardImpl.java:72)
>       at 
> com.intellij.openapi.application.impl.LaterInvocator$FlushQueue.runNextEvent(LaterInvocator.java:416)
>       at 
> com.intellij.openapi.application.impl.LaterInvocator$FlushQueue.run(LaterInvocator.java:399)
>       at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:311)
>       at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:762)
>       at java.awt.EventQueue.access$500(EventQueue.java:98)
>       at java.awt.EventQueue$3.run(EventQueue.java:715)
>       at java.awt.EventQueue$3.run(EventQueue.java:709)
>       at java.security.AccessController.doPrivileged(Native Method)
>       at 
> java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:80)
>       at java.awt.EventQueue.dispatchEvent(EventQueue.java:732)
>       at 
> com.intellij.ide.IdeEventQueue.defaultDispatchEvent(IdeEventQueue.java:821)
>       at com.intellij.ide.IdeEventQueue._dispatchEvent(IdeEventQueue.java:649)
>       at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.java:365)
>       at 
> java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:201)
>       at 
> java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
>       at 
> java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
>       at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
>       at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
>       at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)
> ```
> Does somebody knows about it?
> I'm using IntelliJ 2017-2.5 CE version.
> Thanks



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to