ASF GitHub Bot logged work on BEAM-3995:

                Author: ASF GitHub Bot
            Created on: 11/Apr/18 13:52
            Start Date: 11/Apr/18 13:52
    Worklog Time Spent: 10m 
      Work Description: lukecwik commented on a change in pull request #5051: 
[BEAM-3995] Add basic Gradle run task to Nexmark
URL: https://github.com/apache/beam/pull/5051#discussion_r180760912

 File path: sdks/java/nexmark/build.gradle
 @@ -43,8 +68,53 @@ dependencies {
   shadow project(path: ":beam-runners-direct-java", configuration: "shadow")
   shadow library.java.slf4j_jdk14
   testCompile library.java.hamcrest_core
+  gradleRun project(path: project.path, configuration: "shadow")
+  gradleRun project(path: nexmarkRunnerDependency, configuration: "shadow")
+  // The Spark runner requires the user to provide a Spark dependency. For 
+  // runs with the Spark runner, we can provide such a dependency. This is 
deliberately phrased
+  // to not hardcode any runner other than :runners:direct-java
+  if (shouldProvideSpark) {
+    gradleRun library.java.spark_streaming
+    gradleRun library.java.spark_core, {
+      exclude group:"org.slf4j", module:"jul-to-slf4j"
+    }
+    // TODO: pre-Gradle this was excluded in the SparkRunner overall, in 
Gradle it is
+    // only excluded in the testRuntimeClasspath.
+    gradleRun project(path: ":beam-sdks-java-core", configuration: "shadow"), {
 Review comment:
   You don't need to specify the project, you can just exclude the values 
configuration wide which your doing below.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 89963)
    Time Spent: 5h  (was: 4h 50m)

> Launch Nexmark suites from gradle and update web page docs
> ----------------------------------------------------------
>                 Key: BEAM-3995
>                 URL: https://issues.apache.org/jira/browse/BEAM-3995
>             Project: Beam
>          Issue Type: Sub-task
>          Components: examples-nexmark, website
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>            Priority: Major
>          Time Spent: 5h
>  Remaining Estimate: 0h
> Currently our instructions for running Nexmark benchmarks on various runners 
> is pretty tightly tied to Maven. We need a good story for running them with 
> gradle (or just building an executable with gradle and running that 
> standalone).

This message was sent by Atlassian JIRA

Reply via email to