[ 
https://issues.apache.org/jira/browse/BEAM-3981?focusedWorklogId=90254&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-90254
 ]

ASF GitHub Bot logged work on BEAM-3981:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Apr/18 01:32
            Start Date: 12/Apr/18 01:32
    Worklog Time Spent: 10m 
      Work Description: charlesccychen commented on a change in pull request 
#5053: [BEAM-3981] Futurize coders subpackage
URL: https://github.com/apache/beam/pull/5053#discussion_r180943338
 
 

 ##########
 File path: sdks/python/apache_beam/coders/coders.py
 ##########
 @@ -216,6 +222,9 @@ def __eq__(self, other):
             and self._dict_without_impl() == other._dict_without_impl())
     # pylint: enable=protected-access
 
+  def __hash__(self):
+    return hash(type(self))
 
 Review comment:
   Any particular reason for this change?  Previously, the hash would default 
to `object.__hash__`, which tries to give a different hash code for each 
instance.  This change would give the same hash code for each class, which may 
not be desirable, since coders in general could be parameterized.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 90254)
    Time Spent: 7h 10m  (was: 7h)

> Futurize and fix python 2 compatibility for coders package
> ----------------------------------------------------------
>
>                 Key: BEAM-3981
>                 URL: https://issues.apache.org/jira/browse/BEAM-3981
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-py-core
>            Reporter: Robbe
>            Assignee: Ahmet Altay
>            Priority: Major
>          Time Spent: 7h 10m
>  Remaining Estimate: 0h
>
> Run automatic conversion with futurize tool on coders subpackage and fix 
> python 2 compatibility. This prepares the subpackage for python 3 support.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to