ASF GitHub Bot logged work on BEAM-4028:

                Author: ASF GitHub Bot
            Created on: 12/Apr/18 01:40
            Start Date: 12/Apr/18 01:40
    Worklog Time Spent: 10m 
      Work Description: charlesccychen commented on a change in pull request 
#5043: [BEAM-4028] Adding NameContext to Python SDK.
URL: https://github.com/apache/beam/pull/5043#discussion_r180944556

 File path: sdks/python/apache_beam/runners/worker/operations.py
 @@ -682,14 +701,14 @@ def execute(self):
     # The order of the elements is important because the inputs use
     # list indexes as references.
-    step_names = (
-        self._map_task.step_names or [None] * len(self._map_task.operations))
     for ix, spec in enumerate(self._map_task.operations):
       # This is used for logging and assigning names to counters.
-      operation_name = self._map_task.system_names[ix]
-      step_name = step_names[ix]
+      name_context = common.DataflowNameContext(
 Review comment:
   <!--new_thread; commit:fc000934fceaaeb8c8ca87017a50b4f2cbf35340; 
   Will we always need the Dataflow version here?

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 90258)
    Time Spent: 2h  (was: 1h 50m)

> Step / Operation naming should rely on a NameContext class
> ----------------------------------------------------------
>                 Key: BEAM-4028
>                 URL: https://issues.apache.org/jira/browse/BEAM-4028
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py-core
>            Reporter: Pablo Estrada
>            Assignee: Pablo Estrada
>            Priority: Major
>          Time Spent: 2h
>  Remaining Estimate: 0h
> Steps can have different names depending on the runner (stage, step, user, 
> system name...). 
> Depending on the needs of different components (operations, logging, metrics, 
> statesampling) these step names are passed around without a specific order.
> Instead, SDK should rely on `NameContext` objects that carry all the naming 
> information for a single step.

This message was sent by Atlassian JIRA

Reply via email to