[
https://issues.apache.org/jira/browse/BEAM-3714?focusedWorklogId=90262&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-90262
]
ASF GitHub Bot logged work on BEAM-3714:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Apr/18 01:47
Start Date: 12/Apr/18 01:47
Worklog Time Spent: 10m
Work Description: evindj opened a new pull request #5109:
[BEAM-3714]modified result set to be forward only and read only
URL: https://github.com/apache/beam/pull/5109
DESCRIPTION HERE
------------------------
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the
change (usually before you start working on it). Trivial changes like typos do
not require a JIRA issue. Your pull request should address just this issue,
without pulling in other changes.
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue.
- [ ] Write a pull request description that is detailed enough to
understand:
- [ ] What the pull request does
- [ ] Why it does it
- [ ] How it does it
- [ ] Why this approach
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 90262)
Time Spent: 2.5h (was: 2h 20m)
> JdbcIO.read() should create a forward-only, read-only result set
> ----------------------------------------------------------------
>
> Key: BEAM-3714
> URL: https://issues.apache.org/jira/browse/BEAM-3714
> Project: Beam
> Issue Type: Bug
> Components: io-java-jdbc
> Reporter: Eugene Kirpichov
> Assignee: Innocent
> Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> [https://stackoverflow.com/questions/48784889/streaming-data-from-cloudsql-into-dataflow/48819934#48819934]
> - a user is trying to load a large table from MySQL, and the MySQL JDBC
> driver requires special measures when loading large result sets.
> JdbcIO currently calls simply "connection.prepareStatement(query)"
> https://github.com/apache/beam/blob/bb8c12c4956cbe3c6f2e57113e7c0ce2a5c05009/sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java#L508
> - it should specify type TYPE_FORWARD_ONLY and concurrency CONCUR_READ_ONLY
> - these values should always be used.
> Seems that different databases have different requirements for streaming
> result sets.
> E.g. MySQL requires setting fetch size; PostgreSQL says "The Connection must
> not be in autocommit mode."
> https://jdbc.postgresql.org/documentation/head/query.html#query-with-cursor .
> Oracle, I think, doesn't have any special requirements but I don't know.
> Fetch size should probably still be set to a reasonably large value.
> Seems that the common denominator of these requirements is: set fetch size to
> a reasonably large but not maximum value; disable autocommit (there's nothing
> to commit in read() anyway).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
