[ 
https://issues.apache.org/jira/browse/BEAM-3444?focusedWorklogId=90638&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-90638
 ]

ASF GitHub Bot logged work on BEAM-3444:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Apr/18 23:47
            Start Date: 12/Apr/18 23:47
    Worklog Time Spent: 10m 
      Work Description: shoyer commented on a change in pull request #4376: 
[BEAM-3444] Fix python3 flake8 errors e999
URL: https://github.com/apache/beam/pull/4376#discussion_r181253388
 
 

 ##########
 File path: sdks/python/apache_beam/runners/common.py
 ##########
 @@ -512,7 +514,7 @@ def _reraise_augmented(self, exn):
           traceback.format_exception_only(type(exn), exn)[-1].strip()
           + step_annotation)
       new_exn._tagged_with_step = True
-    raise new_exn, None, original_traceback
+    six.raise_from(new_exn, original_traceback)
 
 Review comment:
   This use of `raise_from` instead of `reraise` led to a bug with dropped 
stacktraces: https://issues.apache.org/jira/projects/BEAM/issues/BEAM-3956
   
   Are the other uses of `raise_from` instead of `reraise` in this PR 
appropriate?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 90638)
    Time Spent: 6h 10m  (was: 6h)

> Fix flake8 detected errors E999 (AST compile error)
> ---------------------------------------------------
>
>                 Key: BEAM-3444
>                 URL: https://issues.apache.org/jira/browse/BEAM-3444
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-py-core
>            Reporter: holdenk
>            Priority: Major
>          Time Spent: 6h 10m
>  Remaining Estimate: 0h
>
> Fix flake8 detected errors E999 (AST compile error) so that we can run flake8 
> to catch potential python3 breaking issues.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to