ASF GitHub Bot logged work on BEAM-3981:

                Author: ASF GitHub Bot
            Created on: 13/Apr/18 08:33
            Start Date: 13/Apr/18 08:33
    Worklog Time Spent: 10m 
      Work Description: RobbeSneyders commented on a change in pull request 
#5053: [BEAM-3981] Futurize coders subpackage
URL: https://github.com/apache/beam/pull/5053#discussion_r181319580

 File path: sdks/python/apache_beam/coders/coders_test_common.py
 @@ -103,7 +104,7 @@ def test_custom_coder(self):
     self.check_coder(CustomCoder(), 1, -10, 5)
     self.check_coder(coders.TupleCoder((CustomCoder(), coders.BytesCoder())),
-                     (1, 'a'), (-10, 'b'), (5, 'c'))
+                     (1, b'a'), (-10, b'b'), (5, b'c'))
 Review comment:
   I guess this is aimed at the 'a' in line 109? 
   The marking of the strings as bytes literals is done manually. I've only 
marked strings as bytes literals when it's clear that they're meant to 
represent bytes (when testing BytesCoder, when the content of the string are 
clearly bytes, ...).  When a string is not marked, it represents `str` on both 
versions, which seems ok for the 'a' at line 109 for example.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 90737)
    Time Spent: 9.5h  (was: 9h 20m)

> Futurize and fix python 2 compatibility for coders package
> ----------------------------------------------------------
>                 Key: BEAM-3981
>                 URL: https://issues.apache.org/jira/browse/BEAM-3981
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-py-core
>            Reporter: Robbe
>            Assignee: Ahmet Altay
>            Priority: Major
>          Time Spent: 9.5h
>  Remaining Estimate: 0h
> Run automatic conversion with futurize tool on coders subpackage and fix 
> python 2 compatibility. This prepares the subpackage for python 3 support.

This message was sent by Atlassian JIRA

Reply via email to