[ 
https://issues.apache.org/jira/browse/BEAM-4056?focusedWorklogId=90993&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-90993
 ]

ASF GitHub Bot logged work on BEAM-4056:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/Apr/18 22:28
            Start Date: 13/Apr/18 22:28
    Worklog Time Spent: 10m 
      Work Description: tgroh commented on a change in pull request #5118: 
[BEAM-4056] Identify side inputs by transform id and local name
URL: https://github.com/apache/beam/pull/5118#discussion_r181523199
 
 

 ##########
 File path: model/pipeline/src/main/proto/beam_runner_api.proto
 ##########
 @@ -217,12 +217,12 @@ message ExecutableStagePayload {
   // PTransform the ExecutableStagePayload is the payload of.
   string input = 2;
 
-  // Side Input PCollection ids. Each must be present as a value in the inputs 
of
-  // any PTransform the ExecutableStagePayload is the payload of.
-  repeated string side_inputs = 3;
+  // The side inputs required for this executable stage. Each must be present 
as a side input of
+  // exactly one PTransform within this ExecutableStagePayload.
 
 Review comment:
   I would modify this spec a little - "Each Side Input of each PTransform 
within this ExecutableStagePayload must be represented within this field." or 
thereabouts.
   
   That way it represents the minimum contents instead of the maximum contents; 
if we make more side inputs available than required, I don't expect either 
harness to break, just to be very confused.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 90993)
    Time Spent: 1.5h  (was: 1h 20m)

> Identify Side Inputs by PTransform ID and local name
> ----------------------------------------------------
>
>                 Key: BEAM-4056
>                 URL: https://issues.apache.org/jira/browse/BEAM-4056
>             Project: Beam
>          Issue Type: New Feature
>          Components: runner-core
>            Reporter: Ben Sidhom
>            Assignee: Ben Sidhom
>            Priority: Minor
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> This is necessary in order to correctly identify side inputs during all 
> phases of portable pipeline execution (fusion, translation, and SDK 
> execution).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to