Romain Manni-Bucau commented on BEAM-4016:

PS: don't forget the teardown mapping for any instance (or use the same caching 
hack direct runer has)

> Direct runner incorrect lifecycle, @SplitRestriction should execute after 
> @Setup on SplittableDoFn
> --------------------------------------------------------------------------------------------------
>                 Key: BEAM-4016
>                 URL: https://issues.apache.org/jira/browse/BEAM-4016
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-direct
>    Affects Versions: 2.4.0
>            Reporter: Ismaël Mejía
>            Assignee: Thomas Groh
>            Priority: Major
>         Attachments: sdf-splitrestriction-lifeycle-test.patch
> The method annotated with @SplitRestriction is the method where we can define 
> the RestrictionTrackers (splits) in advance in a SDF. It makes sense to 
> execute this after the @Setup method given that usually connections are 
> established at Setup and can be used to ask the different data stores about 
> the partitioning strategy. I added a test for this in the 
> SplittableDoFnTest.SDFWithLifecycle test.

This message was sent by Atlassian JIRA

Reply via email to