Reuven Lax commented on BEAM-4077:

every type can be nullable, so this would mean doubling the number of builder 
methods. There already is a a builder method that takes in a Field object 
(addField) which technically provides full generality. The others were added 
simply because I found that it increased ease of use of the builder.

> Refactor builder field nullability
> ----------------------------------
>                 Key: BEAM-4077
>                 URL: https://issues.apache.org/jira/browse/BEAM-4077
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
>            Priority: Major
> Currently the Schema builder methods take a boolean for nullability. It would 
> be more standard to have separate builder methods. At this point the builder 
> might as well just take the Field spec since it does not add concision.

This message was sent by Atlassian JIRA

Reply via email to