[
https://issues.apache.org/jira/browse/BEAM-3327?focusedWorklogId=91788&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-91788
]
ASF GitHub Bot logged work on BEAM-3327:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Apr/18 16:03
Start Date: 17/Apr/18 16:03
Worklog Time Spent: 10m
Work Description: tgroh closed pull request #5144: [BEAM-3327] Rename
EnvironmentManager to EnvironmentFactory
URL: https://github.com/apache/beam/pull/5144
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/environment/EnvironmentManager.java
b/runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/environment/EnvironmentFactory.java
similarity index 97%
rename from
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/environment/EnvironmentManager.java
rename to
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/environment/EnvironmentFactory.java
index 445d3f3e4c5..8a47d54f324 100644
---
a/runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/environment/EnvironmentManager.java
+++
b/runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/environment/EnvironmentFactory.java
@@ -26,12 +26,12 @@
* Manages access to {@link Environment environments} which communicate to an
{@link
* SdkHarnessClient}.
*/
-public interface EnvironmentManager {
+public interface EnvironmentFactory {
/**
* Retrieve a handle to an active {@link Environment}. This may allocate
resources if required.
*
* <p>TODO: Determine and document the owner of the returned environment. If
the environment is
- * owned by the manager, make the Manager {@link AutoCloseable}..
+ * owned by the manager, make the Manager {@link AutoCloseable}.
*/
RemoteEnvironment getEnvironment(RunnerApi.Environment container) throws
Exception;
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 91788)
Time Spent: 6h 40m (was: 6.5h)
> Add abstractions to manage Environment Instance lifecycles.
> -----------------------------------------------------------
>
> Key: BEAM-3327
> URL: https://issues.apache.org/jira/browse/BEAM-3327
> Project: Beam
> Issue Type: New Feature
> Components: runner-core
> Reporter: Thomas Groh
> Assignee: Axel Magnuson
> Priority: Major
> Labels: portability
> Time Spent: 6h 40m
> Remaining Estimate: 0h
>
> This permits remote stage execution for arbitrary environments
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
