[
https://issues.apache.org/jira/browse/BEAM-3776?focusedWorklogId=91795&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-91795
]
ASF GitHub Bot logged work on BEAM-3776:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Apr/18 16:09
Start Date: 17/Apr/18 16:09
Worklog Time Spent: 10m
Work Description: tgroh commented on issue #4793: [BEAM-3776] Fix issue
with merging late windows where a watermark hold could be added behind the
input watermark.
URL: https://github.com/apache/beam/pull/4793#issuecomment-382050089
Sorry to come back so late after with requests - can you rebase on top of
master? The precommit that seems to be running seems to be looking for targets
that don't exist on your revision, if I read some of the issues properly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 91795)
Time Spent: 5h 20m (was: 5h 10m)
> StateMerging.mergeWatermarks sets a late watermark hold for late merging
> windows that depend only on the window
> ---------------------------------------------------------------------------------------------------------------
>
> Key: BEAM-3776
> URL: https://issues.apache.org/jira/browse/BEAM-3776
> Project: Beam
> Issue Type: Bug
> Components: runner-core
> Affects Versions: 2.1.0, 2.2.0, 2.3.0
> Reporter: Sam Whittle
> Assignee: Sam Whittle
> Priority: Critical
> Time Spent: 5h 20m
> Remaining Estimate: 0h
>
> WatermarkHold.addElementHold and WatermarkHold.addGarbageCollectionHold take
> to not add holds that would be before the input watermark.
> However WatermarkHold.onMerge calls StateMerging.mergeWatermarks which if the
> window depends only on window, sets a hold for the end of the window
> regardless of the input watermark.
> Thus if you have a WindowingStrategy such as:
> WindowingStrategy.of(Sessions.withGapDuration(gapDuration))
> .withMode(AccumulationMode.DISCARDING_FIRED_PANES)
> .withTrigger(
> Repeatedly.forever(
> AfterWatermark.pastEndOfWindow()
> .withLateFirings(AfterPane.elementCountAtLeast(10))))
> .withAllowedLateness(allowedLateness))
> and you merge windows that are late, you might end up holding the watermark
> until the allowedLateness has passed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
