[
https://issues.apache.org/jira/browse/BEAM-4071?focusedWorklogId=91884&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-91884
]
ASF GitHub Bot logged work on BEAM-4071:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Apr/18 20:22
Start Date: 17/Apr/18 20:22
Worklog Time Spent: 10m
Work Description: jkff commented on a change in pull request #5150:
[BEAM-4071] Add Portable Runner Job API shim
URL: https://github.com/apache/beam/pull/5150#discussion_r181924543
##########
File path:
runners/local-artifact-service-java/src/test/java/org/apache/beam/artifact/local/LocalFileSystemArtifactRetrievalServiceTest.java
##########
@@ -186,11 +187,11 @@ public void onCompleted() {
}
private void stageAndCreateRetrievalService(Map<String, byte[]> artifacts)
throws Exception {
- List<File> artifactFiles = new ArrayList<>();
+ List<FileToStage> artifactFiles = new ArrayList<>();
for (Map.Entry<String, byte[]> artifact : artifacts.entrySet()) {
File artifactFile = tmp.newFile(artifact.getKey());
new
FileOutputStream(artifactFile).getChannel().write(ByteBuffer.wrap(artifact.getValue()));
- artifactFiles.add(artifactFile);
+ artifactFiles.add(FileToStage.of(artifactFile, artifactFile.getName()));
Review comment:
That line above is funky, why not just `Files.write(artifactFile.getPath(),
artifact.getValue())`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 91884)
Time Spent: 0.5h (was: 20m)
> Portable Runner Job API shim
> ----------------------------
>
> Key: BEAM-4071
> URL: https://issues.apache.org/jira/browse/BEAM-4071
> Project: Beam
> Issue Type: New Feature
> Components: runner-core
> Reporter: Ben Sidhom
> Assignee: Ben Sidhom
> Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> There needs to be a way to execute Java-SDK pipelines against a portable job
> server. The job server itself is expected to be started up out-of-band. The
> "PortableRunner" should take an option indicating the Job API endpoint and
> defer other runner configurations to the backend itself.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
