[
https://issues.apache.org/jira/browse/BEAM-4070?focusedWorklogId=91915&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-91915
]
ASF GitHub Bot logged work on BEAM-4070:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Apr/18 20:29
Start Date: 17/Apr/18 20:29
Worklog Time Spent: 10m
Work Description: boyuanzz closed pull request #5134: [BEAM-4070]: Make
cython: profile=False by default
URL: https://github.com/apache/beam/pull/5134
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/sdks/python/apache_beam/coders/coder_impl.pxd
b/sdks/python/apache_beam/coders/coder_impl.pxd
index 98dd508556a..829b789ec81 100644
--- a/sdks/python/apache_beam/coders/coder_impl.pxd
+++ b/sdks/python/apache_beam/coders/coder_impl.pxd
@@ -15,7 +15,7 @@
# limitations under the License.
#
-# cython: profile=True
+# cython: profile=False
cimport cython
diff --git a/sdks/python/apache_beam/runners/common.py
b/sdks/python/apache_beam/runners/common.py
index 44f9083a52b..184b45e6f41 100644
--- a/sdks/python/apache_beam/runners/common.py
+++ b/sdks/python/apache_beam/runners/common.py
@@ -15,7 +15,7 @@
# limitations under the License.
#
-# cython: profile=True
+# cython: profile=False
"""Worker operations executor.
diff --git a/sdks/python/apache_beam/runners/worker/opcounters.py
b/sdks/python/apache_beam/runners/worker/opcounters.py
index 17fead28ed2..5bfed0b34e1 100644
--- a/sdks/python/apache_beam/runners/worker/opcounters.py
+++ b/sdks/python/apache_beam/runners/worker/opcounters.py
@@ -15,7 +15,7 @@
# limitations under the License.
#
-# cython: profile=True
+# cython: profile=False
"""Counters collect the progress of the Worker for reporting to the service."""
diff --git a/sdks/python/apache_beam/runners/worker/operations.py
b/sdks/python/apache_beam/runners/worker/operations.py
index 977d4bba095..546470418cb 100644
--- a/sdks/python/apache_beam/runners/worker/operations.py
+++ b/sdks/python/apache_beam/runners/worker/operations.py
@@ -15,7 +15,7 @@
# limitations under the License.
#
-# cython: profile=True
+# cython: profile=False
"""Worker operations executor."""
diff --git a/sdks/python/apache_beam/runners/worker/statesampler_fast.pyx
b/sdks/python/apache_beam/runners/worker/statesampler_fast.pyx
index 37d7c09da46..d6f21543483 100644
--- a/sdks/python/apache_beam/runners/worker/statesampler_fast.pyx
+++ b/sdks/python/apache_beam/runners/worker/statesampler_fast.pyx
@@ -15,7 +15,7 @@
# limitations under the License.
#
-# cython: profile=True
+# cython: profile=False
"""State sampler for tracking time spent in execution steps.
diff --git
a/sdks/python/apache_beam/transforms/cy_dataflow_distribution_counter.pxd
b/sdks/python/apache_beam/transforms/cy_dataflow_distribution_counter.pxd
index d4711bd3880..9661acff8c0 100644
--- a/sdks/python/apache_beam/transforms/cy_dataflow_distribution_counter.pxd
+++ b/sdks/python/apache_beam/transforms/cy_dataflow_distribution_counter.pxd
@@ -14,7 +14,7 @@
# limitations under the License.
#
-# cython: profile=True
+# cython: profile=False
""" For internal use only. No backwards compatibility guarantees."""
diff --git
a/sdks/python/apache_beam/transforms/cy_dataflow_distribution_counter.pyx
b/sdks/python/apache_beam/transforms/cy_dataflow_distribution_counter.pyx
index a3622aac40b..cc770427b3f 100644
--- a/sdks/python/apache_beam/transforms/cy_dataflow_distribution_counter.pyx
+++ b/sdks/python/apache_beam/transforms/cy_dataflow_distribution_counter.pyx
@@ -14,7 +14,7 @@
# limitations under the License.
#
-# cython: profile=True
+# cython: profile=False
""" For internal use only. No backwards compatibility guarantees."""
diff --git a/sdks/python/apache_beam/utils/counters.pxd
b/sdks/python/apache_beam/utils/counters.pxd
index b8addb28223..5c78da6e25d 100644
--- a/sdks/python/apache_beam/utils/counters.pxd
+++ b/sdks/python/apache_beam/utils/counters.pxd
@@ -15,7 +15,7 @@
# limitations under the License.
#
-# cython: profile=True
+# cython: profile=False
# cython: overflowcheck=True
cdef class Counter(object):
diff --git a/sdks/python/apache_beam/utils/windowed_value.py
b/sdks/python/apache_beam/utils/windowed_value.py
index 1b3228b2e6e..dcbe674c85c 100644
--- a/sdks/python/apache_beam/utils/windowed_value.py
+++ b/sdks/python/apache_beam/utils/windowed_value.py
@@ -25,7 +25,7 @@
# editing this file as WindowedValues are created for every element for
# every step in a Beam pipeline.
-#cython: profile=True
+#cython: profile=False
from apache_beam.utils.timestamp import MAX_TIMESTAMP
from apache_beam.utils.timestamp import MIN_TIMESTAMP
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 91915)
Time Spent: 2h (was: 1h 50m)
> Disable cython profiling by default
> -----------------------------------
>
> Key: BEAM-4070
> URL: https://issues.apache.org/jira/browse/BEAM-4070
> Project: Beam
> Issue Type: Task
> Components: sdk-py-core
> Reporter: Boyuan Zhang
> Assignee: Boyuan Zhang
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Enabling cython profiling adds some overhead.
> http://cython.readthedocs.io/en/latest/src/tutorial/profiling_tutorial.html
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
