[
https://issues.apache.org/jira/browse/BEAM-4099?focusedWorklogId=91930&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-91930
]
ASF GitHub Bot logged work on BEAM-4099:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Apr/18 21:27
Start Date: 17/Apr/18 21:27
Worklog Time Spent: 10m
Work Description: aaltay closed pull request #5153: [BEAM-4099] Rebuild
project before running Performance tests on Jenkins
URL: https://github.com/apache/beam/pull/5153
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/.test-infra/jenkins/job_beam_PerformanceTests_FileBasedIO_IT.groovy
b/.test-infra/jenkins/job_beam_PerformanceTests_FileBasedIO_IT.groovy
index b5558c08144..dc382c1f9bd 100644
--- a/.test-infra/jenkins/job_beam_PerformanceTests_FileBasedIO_IT.groovy
+++ b/.test-infra/jenkins/job_beam_PerformanceTests_FileBasedIO_IT.groovy
@@ -121,7 +121,7 @@ private void
create_filebasedio_performance_test_job(testConfiguration) {
benchmarks : 'beam_integration_benchmark',
beam_it_timeout : '1200',
beam_it_profile : 'io-it',
- beam_prebuilt : 'true',
+ beam_prebuilt : 'false',
beam_sdk : 'java',
beam_it_module : 'sdks/java/io/file-based-io-tests',
beam_it_class : testConfiguration.itClass,
diff --git
a/.test-infra/jenkins/job_beam_PerformanceTests_FileBasedIO_IT_HDFS.groovy
b/.test-infra/jenkins/job_beam_PerformanceTests_FileBasedIO_IT_HDFS.groovy
index 19c0f074e80..7aa5c3251c0 100644
--- a/.test-infra/jenkins/job_beam_PerformanceTests_FileBasedIO_IT_HDFS.groovy
+++ b/.test-infra/jenkins/job_beam_PerformanceTests_FileBasedIO_IT_HDFS.groovy
@@ -132,7 +132,7 @@ private void
create_filebasedio_performance_test_job(testConfiguration) {
benchmarks : 'beam_integration_benchmark',
beam_it_timeout : '1200',
beam_it_profile : 'io-it',
- beam_prebuilt : 'true',
+ beam_prebuilt : 'false',
beam_sdk : 'java',
beam_it_module : 'sdks/java/io/file-based-io-tests',
beam_it_class : testConfiguration.itClass,
diff --git
a/.test-infra/jenkins/job_beam_PerformanceTests_HadoopInputFormat.groovy
b/.test-infra/jenkins/job_beam_PerformanceTests_HadoopInputFormat.groovy
index 093390dc930..a4182858f8e 100644
--- a/.test-infra/jenkins/job_beam_PerformanceTests_HadoopInputFormat.groovy
+++ b/.test-infra/jenkins/job_beam_PerformanceTests_HadoopInputFormat.groovy
@@ -51,7 +51,7 @@ job('beam_PerformanceTests_HadoopInputFormat') {
beam_it_timeout : '1200',
benchmarks : 'beam_integration_benchmark',
beam_it_profile : 'io-it',
- beam_prebuilt : 'true',
+ beam_prebuilt : 'false',
beam_sdk : 'java',
beam_it_module : 'sdks/java/io/hadoop-input-format',
beam_it_class :
'org.apache.beam.sdk.io.hadoop.inputformat.HadoopInputFormatIOIT',
diff --git a/.test-infra/jenkins/job_beam_PerformanceTests_JDBC.groovy
b/.test-infra/jenkins/job_beam_PerformanceTests_JDBC.groovy
index 401a9104e6a..30964a0db0f 100644
--- a/.test-infra/jenkins/job_beam_PerformanceTests_JDBC.groovy
+++ b/.test-infra/jenkins/job_beam_PerformanceTests_JDBC.groovy
@@ -51,7 +51,7 @@ job('beam_PerformanceTests_JDBC') {
beam_it_timeout : '1800',
benchmarks : 'beam_integration_benchmark',
beam_it_profile : 'io-it',
- beam_prebuilt : 'true',
+ beam_prebuilt : 'false',
beam_sdk : 'java',
beam_it_module : 'sdks/java/io/jdbc',
beam_it_class : 'org.apache.beam.sdk.io.jdbc.JdbcIOIT',
diff --git a/.test-infra/jenkins/job_beam_PerformanceTests_MongoDBIO_IT.groovy
b/.test-infra/jenkins/job_beam_PerformanceTests_MongoDBIO_IT.groovy
index 1cd469c3320..31cfc5138a2 100644
--- a/.test-infra/jenkins/job_beam_PerformanceTests_MongoDBIO_IT.groovy
+++ b/.test-infra/jenkins/job_beam_PerformanceTests_MongoDBIO_IT.groovy
@@ -50,7 +50,7 @@ job('beam_PerformanceTests_MongoDBIO_IT') {
beam_it_timeout : '1800',
benchmarks : 'beam_integration_benchmark',
beam_it_profile : 'io-it',
- beam_prebuilt : 'true',
+ beam_prebuilt : 'false',
beam_sdk : 'java',
beam_it_module : 'sdks/java/io/mongodb',
beam_it_class :
'org.apache.beam.sdk.io.mongodb.MongoDBIOIT',
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 91930)
Time Spent: 0.5h (was: 20m)
> Always rebuild beam before running Performance Tests on Jenkins
> ---------------------------------------------------------------
>
> Key: BEAM-4099
> URL: https://issues.apache.org/jira/browse/BEAM-4099
> Project: Beam
> Issue Type: Task
> Components: testing
> Reporter: Łukasz Gajowy
> Assignee: Łukasz Gajowy
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently performance tests running on Jenkins all have "beam_prebuilt" [1]
> Perfkit's flag set to true, which means that PerfKit does not rebuild the
> code before invoking the Performance Test. This makes things faster but error
> prone - we observed Performance Tests failures several times due to the fact
> that something was not built on time.
>
> We should rebuild Beam in every testing job to avoid errors (only "bare"
> build, without tests and checkstyle). This will make the tests last longer
> (about 7 minutes per each test, as my experiments have shown). Probably it
> will be faster on Gradle (didn't test it yet). There are 12 tests now with
> "beam_PerformanceTests_JDBC" as the longest lasting (total of 15 minutes).
> [1]
> https://beam.apache.org/documentation/io/testing/#implementing-integration-tests
> Link to mailing list discussion:
> [https://lists.apache.org/thread.html/503d284084103d605c8b56055ff82849784914b99549630977df5214@%3Cdev.beam.apache.org%3E]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
