[
https://issues.apache.org/jira/browse/BEAM-4038?focusedWorklogId=92002&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-92002
]
ASF GitHub Bot logged work on BEAM-4038:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Apr/18 23:43
Start Date: 17/Apr/18 23:43
Worklog Time Spent: 10m
Work Description: gkumar7 commented on a change in pull request #5111:
[BEAM-4038] Support Kafka Headers in KafkaIO
URL: https://github.com/apache/beam/pull/5111#discussion_r182273112
##########
File path:
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaRecordCoder.java
##########
@@ -66,9 +76,24 @@ public void encode(KafkaRecord<K, V> value, OutputStream
outStream) throws IOExc
longCoder.decode(inStream),
longCoder.decode(inStream),
KafkaTimestampType.forOrdinal(intCoder.decode(inStream)),
+ getHeaders(headerCoder.decode(inStream)),
kvCoder.decode(inStream));
}
+ private Headers getHeaders(Iterable<KV<String, byte[]>> records) {
+ Headers headers = new RecordHeaders();
Review comment:
Instantiating via ```ConsumerRecord``` is a bit hacky. It should be fine if
we use ```RecordHeaders``` directly. If it was not meant to be used, it should
be encapsulated more thoroughly (package-private).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 92002)
Time Spent: 5h 10m (was: 5h)
> Support Kafka Headers in KafkaIO
> --------------------------------
>
> Key: BEAM-4038
> URL: https://issues.apache.org/jira/browse/BEAM-4038
> Project: Beam
> Issue Type: New Feature
> Components: io-java-kafka
> Reporter: Geet Kumar
> Assignee: Raghu Angadi
> Priority: Minor
> Time Spent: 5h 10m
> Remaining Estimate: 0h
>
> Headers have been added to Kafka Consumer/Producer records (KAFKA-4208). The
> purpose of this JIRA is to support this feature in KafkaIO.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
