[
https://issues.apache.org/jira/browse/BEAM-3746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16443319#comment-16443319
]
Batkhuyag Batsaikhan commented on BEAM-3746:
--------------------------------------------
Actually, *Count.globally().withoutDefaults()* is identical to
*Combine.globally(Count.<T>combineFn()).withoutDefaults()*. I think the javadoc
should be changed.
> Count.globally should override getIncompatibleGlobalWindowErrorMessage to
> tell the user the usage that is currently only in javadoc
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: BEAM-3746
> URL: https://issues.apache.org/jira/browse/BEAM-3746
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Kenneth Knowles
> Assignee: Batkhuyag Batsaikhan
> Priority: Major
> Labels: beginner, newbie, starter
>
> https://beam.apache.org/documentation/sdks/javadoc/2.3.0/org/apache/beam/sdk/transforms/Count.html#globally--
> "Note: if the input collection uses a windowing strategy other than
> GlobalWindows, use Combine.globally(Count.<T>combineFn()).withoutDefaults()
> instead."
> But the actual crash a user gets is:
> "java.lang.IllegalStateException: Default values are not supported in
> Combine.globally() if the output PCollection is not windowed by
> GlobalWindows. Instead, use Combine.globally().withoutDefaults() to output an
> empty PCollection if the input PCollection is empty, or
> Combine.globally().asSingletonView() to get the default output of the
> CombineFn if the input PCollection is empty."
> There is a method that exists solely to make this actually useful, so we
> should use it!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
