[ 
https://issues.apache.org/jira/browse/BEAM-3433?focusedWorklogId=92345&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-92345
 ]

ASF GitHub Bot logged work on BEAM-3433:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 19/Apr/18 02:06
            Start Date: 19/Apr/18 02:06
    Worklog Time Spent: 10m 
      Work Description: kvncp opened a new pull request #5178: [BEAM-3433] 
Allow a GCP project to be explicitly set for a load job
URL: https://github.com/apache/beam/pull/5178
 
 
   I've added the needed string parameter to the BigQueryIO.write() function, 
and passed it through to the underlying class. Wanted to get some feedback 
before trying to write a test.
   
   1. Should I also add a ValueProvider<String> interface?
   2. I've modified the constructor for WriteTables, which is public. Should I 
instead add a setter for that function or overload the constructor?
   3. Should I validate the this parameter is not set unless the Method is 
FILE_LOADS? It isn't harmful to set it otherwise, it is just ignored. Not sure 
what the recommendation is in that case.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 92345)
            Time Spent: 10m
    Remaining Estimate: 0h

> Allow BigQueryIO to use a different project for the load job in batch mode.
> ---------------------------------------------------------------------------
>
>                 Key: BEAM-3433
>                 URL: https://issues.apache.org/jira/browse/BEAM-3433
>             Project: Beam
>          Issue Type: Bug
>          Components: io-java-gcp
>            Reporter: Kevin Peterson
>            Assignee: Chamikara Jayalath
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> BigQueryIO is currently configured to always run a batch load job using the 
> same projects as the destination table: 
> https://github.com/apache/beam/blob/192b4c70927901860312f8c8acd27bd47e4a4259/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/WriteTables.java#L256
> This may not always be desirable, since a pipeline may have write access to a 
> dataset in a different project, but not jobs.create access in that project. 
> This parameter should be settable in the interface.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to