[
https://issues.apache.org/jira/browse/BEAM-3310?focusedWorklogId=92448&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-92448
]
ASF GitHub Bot logged work on BEAM-3310:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Apr/18 08:08
Start Date: 19/Apr/18 08:08
Worklog Time Spent: 10m
Work Description: echauchot commented on a change in pull request #4548:
[BEAM-3310] Metrics pusher
URL: https://github.com/apache/beam/pull/4548#discussion_r182663955
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkRunner.java
##########
@@ -130,8 +133,13 @@ public PipelineResult run(Pipeline pipeline) {
LOG.info("{} : {}", entry.getKey(), entry.getValue());
}
}
-
- return new FlinkRunnerResult(accumulators, result.getNetRuntime());
+ FlinkRunnerResult flinkRunnerResult = new FlinkRunnerResult(accumulators,
+ result.getNetRuntime());
+ MetricsPusher metricsPusher =
+ new MetricsPusher(
+ flinkRunnerResult.getMetricsContainerStepMap(), options,
flinkRunnerResult);
+ metricsPusher.start();
Review comment:
it is stopped in MetricsPusher#tearDown() which is called when an iteration
of the pushing thread detects that the pipeline is in a terminal state.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 92448)
Time Spent: 6h 10m (was: 6h)
> Push metrics to a backend in an runner agnostic way
> ---------------------------------------------------
>
> Key: BEAM-3310
> URL: https://issues.apache.org/jira/browse/BEAM-3310
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-core
> Reporter: Etienne Chauchot
> Assignee: Etienne Chauchot
> Priority: Major
> Time Spent: 6h 10m
> Remaining Estimate: 0h
>
> The idea is to avoid relying on the runners to provide access to the metrics
> (either at the end of the pipeline or while it runs) because they don't have
> all the same capabilities towards metrics (e.g. spark runner configures sinks
> like csv, graphite or in memory sinks using the spark engine conf). The
> target is to push the metrics in the common runner code so that no matter the
> chosen runner, a user can get his metrics out of beam.
> Here is the link to the discussion thread on the dev ML:
> https://lists.apache.org/thread.html/01a80d62f2df6b84bfa41f05e15fda900178f882877c294fed8be91e@%3Cdev.beam.apache.org%3E
> And the design doc:
> https://s.apache.org/runner_independent_metrics_extraction
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
